Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search-include-fragment ui:param - dataverseLinksStayOnPage == true ? #1521

Closed
mheppler opened this issue Feb 26, 2015 · 2 comments
Closed

search-include-fragment ui:param - dataverseLinksStayOnPage == true ? #1521

mheppler opened this issue Feb 26, 2015 · 2 comments
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@mheppler
Copy link
Contributor

mheppler commented Feb 26, 2015 •
edited by pdurbin
Loading 

<ui:param name="dataversePage" value="#{dataverseLinksStayOnPage == true ? '' : '/dataverse.xhtml' }"/>

That is from the search-include-fragment. No one seems to know what it is or what it does or why it was added. Look into it, and remove if not needed.
@mheppler mheppler added this to the In Review - 4.0 milestone Feb 26, 2015
@scolapasta scolapasta modified the milestones: In Review - 4.0.x, In Review - 4.0 Feb 26, 2015
@scolapasta scolapasta removed their assignment Jan 27, 2016
@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner Component: Code Infrastructure formerly "Feature: Code Infrastructure" labels Jan 28, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@pdurbin pdurbin self-assigned this Jun 27, 2017
@pdurbin pdurbin removed the zTriaged label Jun 27, 2017
@pdurbin
Copy link
Member

pdurbin commented Jun 28, 2017

@mheppler it was added in 84facac because at the time we were using the search-include-fragment across the "dataverse" page (the home page) and the "data related to me" page. These days "data related to me" has been replaced with "my data" so dataverseLinksStayOnPage can be safely removed.

@pdurbin pdurbin removed their assignment Jun 28, 2017
@mheppler
Copy link
Contributor Author

Removing in the 3776-public-only branch for issue #3776. Will add note to that issue. Closing this issue.

mheppler added a commit that referenced this issue Jun 28, 2017
@mheppler
Removed "dataverseLinksStayOnPage" param no longer in use. [ref #3776 #…
3284a01 
…1521]
@mheppler mheppler mentioned this issue Jun 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pdurbin @mheppler @scolapasta