Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review indexing for deaccessioned datasets #1853

Closed
scolapasta opened this issue Apr 2, 2015 · 3 comments
Closed

Review indexing for deaccessioned datasets #1853

scolapasta opened this issue Apr 2, 2015 · 3 comments
Assignees
Milestone

Comments

@scolapasta
Copy link
Contributor

A late change removed the indexing of files from deaccessioned datasets - this is likey what we want going forawrd, but we should review the idea (and the code).

@scolapasta scolapasta added this to the 4.0.1 milestone Apr 2, 2015
@pdurbin
Copy link
Member

pdurbin commented Apr 21, 2015

A late change removed the indexing of files from deaccessioned datasets

No. On July 9, 2014 in a design meeting it was decided, "You should never see a card for deaccessioned files. We only show cards for deaccessioned datasets." -- https://docs.google.com/document/d/1lFcwjtdGIqqQLYYnwtTI2GZNzmzYlrnMk2omGcXO9oY/edit?usp=sharing

@scolapasta are you reversing that design decision? It was implemented in #57. /cc @eaquigley @mheppler @posixeleni @sekmiller also commented on that design doc or attended the meeting.

@scolapasta
Copy link
Contributor Author

This issue was created at a time when we were quickly debugging things - from the code it was not apparent that deaccessioned files were not being indexed, however they were. So this is a non issue.

@scolapasta scolapasta assigned kcondon and unassigned scolapasta Apr 21, 2015
@scolapasta scolapasta modified the milestones: Candidates for 4.0.1, 4.0.1 May 8, 2015
@kcondon
Copy link
Contributor

kcondon commented Jun 4, 2015

Non issue, closing.

@kcondon kcondon closed this as completed Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants