-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement discoverability rules for search/browse in 4.0 (permissions) #57
Comments
Original Redmine Comment The main reason we moved this out of beta is that permissions are not fully implemented. For now, we're looking the creator of dataverse or dataset to decide whether or not it should be discoverable before it has been published. See also #3795 which has a lot of permissions-related code. The main commit where we starting using the Solr JOIN feature is this one: some discovery rules for search/browse #3464 · 2505cb7 · IQSS/dataverse - 2505cb7 |
Some thinking from https://docs.google.com/spreadsheet/ccc?key=0AvqMYwdHFZghdFNpVDNvcnh4cTZ5amFwdkExcDU1Q1E&usp=sharing Please note that "Anonymous" also covers "logged in but no explicitly granted read or write access". |
- more use of targeted reindexing of permissions - experimental join is still disabled for now - general cleanup and refactoring
- no more per-group Solr docs - all perms are a sidecar to each set of docs for each dvobjectid
For Beta 9 anyway, we are not inheriting permissions from parent dataverse because permissionRoot was hard-coded to true in fb7e65f In the Google Spreadsheet I added a new sheet for Beta 2 and will attached a screenshot below to show the expected behavior. Passing to QA. |
Also, "unpublished" can mean "deaccessioned" so in the screenshot below, when it says "yes" for either "draft" or "deaccessioned", this should mean that people with ViewUnpublishedDataset permission should be able to them: This screenshot comes from https://docs.google.com/document/d/1lFcwjtdGIqqQLYYnwtTI2GZNzmzYlrnMk2omGcXO9oY/edit?usp=sharing |
Created View unpublished DV and DS role, assigned the role to user and iterated through the list of cases from the google spreadsheet: |
I can't test deaccession part of this ticket because of a 500 error on deaccessioning. Opened a new one to fully test the feature #1209 |
* First db table and api. * Final changes for prototype. * Add integration tests. * Fix indentation. * Add prototype of newest changes. * Add URI and URL objects, and new endpoints. * Add Apache icons. * Change tokens to licenses. * Change URIException to IllegalStateException.
Author Name: Philip Durbin (@pdurbin)
Original Redmine Issue: 3464, https://redmine.hmdc.harvard.edu/issues/3464
Original Assignee: Philip Durbin
The rules are being finalized here: https://trello.com/c/CkRb3dYl/49-define-search-browse-permissions-discoverability-rules
In previous discussions around Lucene, we started looking at these links to help us implement the rules we want:
Related issue(s): #341, #380
Redmine related issue(s): 3430, 3756, 3795
The text was updated successfully, but these errors were encountered: