Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing: Allow authorized users other than creator to search and browse draft and deaccessioned users. #734

Closed
kcondon opened this issue Jul 15, 2014 · 7 comments
Assignees
Labels
Feature: Search/Browse Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@kcondon
Copy link
Contributor

kcondon commented Jul 15, 2014

Currently only creators can see draft and deaccessioned versions when the requirements allow for authorized users to see them.

I believe in this context authorized= edit perms.

@kcondon kcondon added this to the Dataverse 4.0: Beta 2 milestone Jul 15, 2014
@pdurbin
Copy link
Member

pdurbin commented Jul 15, 2014

#57 (Implement discoverability rules for search/browse) is the ticket I've kept open until we get away from the idea that only the creator can see unpublished and deaccessioned things. That ticket is actually broader since it has to do with dataverses as well.

I believe in this context authorized= edit perms.

This is a fairly critical question. I plan to look at the Object/Permission Matrix at https://docs.google.com/spreadsheet/ccc?key=0AmFIRWc1bL0QdFRLbTVORUNyVENac1EwUHBfSTBtRmc&usp=sharing for guidance on what permissions to check. Also, I'll ask @sekmiller to show me what permissions he's checking that lead to @kcondon noticing the mismatch.

At index time, I think I'm going to need methods at the dataset level (for example) to retrieve a list of groups and users that have the appropriate (edit?) permission. Perhaps these groups and users will actually be RoleAssigneeRecords depending on how @michbarsinai and I implement groups. As of this writing, the way we hide non-public things is by doing a Solr JOIN on per-user groups:

* Unless you're part of some special group, you get the "User

@pdurbin
Copy link
Member

pdurbin commented Dec 2, 2014

Moving to QA. Please see #57 (comment) for specifics about expected behavior for Beta 9, especially with regard to inheritance of search permissions.

@esotiri esotiri self-assigned this Dec 2, 2014
@esotiri
Copy link
Contributor

esotiri commented Dec 3, 2014

Authenticated user with ViewUnpublishedDataset and ViewUnpublishedDV permission can see respective objects.
Working for ViewUnpublishedDataset drafts DS.

@esotiri esotiri closed this as completed Dec 3, 2014
@esotiri esotiri reopened this Dec 3, 2014
@esotiri
Copy link
Contributor

esotiri commented Dec 3, 2014

Can not test search perms for deaccession DS due to #1207
Changing to milestone 10 for this specific issue.

@pdurbin
Copy link
Member

pdurbin commented Dec 11, 2014

65fb3906-7af4-11e4-9c58-f931eec20221

screenshot from #57 (comment)

@esotiri
Copy link
Contributor

esotiri commented Dec 19, 2014

authenticated users with view unpublished dataverse and dataset roles can view draft and deaccessioned datasets.
If first version is deaccessioned, user can still see higher versions.

@esotiri esotiri closed this as completed Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Search/Browse Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants