-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexing: Allow authorized users other than creator to search and browse draft and deaccessioned users. #734
Comments
#57 (Implement discoverability rules for search/browse) is the ticket I've kept open until we get away from the idea that only the creator can see unpublished and deaccessioned things. That ticket is actually broader since it has to do with dataverses as well.
This is a fairly critical question. I plan to look at the Object/Permission Matrix at https://docs.google.com/spreadsheet/ccc?key=0AmFIRWc1bL0QdFRLbTVORUNyVENac1EwUHBfSTBtRmc&usp=sharing for guidance on what permissions to check. Also, I'll ask @sekmiller to show me what permissions he's checking that lead to @kcondon noticing the mismatch. At index time, I think I'm going to need methods at the dataset level (for example) to retrieve a list of groups and users that have the appropriate (edit?) permission. Perhaps these groups and users will actually be RoleAssigneeRecords depending on how @michbarsinai and I implement groups. As of this writing, the way we hide non-public things is by doing a Solr JOIN on per-user groups:
|
- can't fix file indexing until dataset page works or sword auth works
Moving to QA. Please see #57 (comment) for specifics about expected behavior for Beta 9, especially with regard to inheritance of search permissions. |
I am going to test rules Phil nicely wrote on https://cloud.githubusercontent.com/assets/21006/5267845/72605d02-7a22-11e4-9a3e-5bcf376b1608.png |
Authenticated user with ViewUnpublishedDataset and ViewUnpublishedDV permission can see respective objects. |
Can not test search perms for deaccession DS due to #1207 |
screenshot from #57 (comment) |
authenticated users with view unpublished dataverse and dataset roles can view draft and deaccessioned datasets. |
Currently only creators can see draft and deaccessioned versions when the requirements allow for authorized users to see them.
I believe in this context authorized= edit perms.
The text was updated successfully, but these errors were encountered: