Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published children should not be generally visible if parent is unpublished. #439

Closed
eaquigley opened this issue Jul 9, 2014 · 4 comments
Assignees
Labels
Type: Bug a defect

Comments

@eaquigley
Copy link
Contributor


Author Name: Kevin Condon (@kcondon)
Original Redmine Issue: 3854, https://redmine.hmdc.harvard.edu/issues/3854
Original Date: 2014-04-14
Original Assignee: Kevin Condon


This was reported by Liz and Phil.

When Root is unreleased, a user can create and publish both dv's and datasets. Once these are published, they are browseable and searchable as a guest as if the parent, root, were also published.

This should not happen.

Thoughts are either to not make children visible if parent is unpublished or to not allow children to be published if parent is unpublished.


Related issue(s): #57, #215
Redmine related issue(s): 3464, 3629


@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Kevin Condon (@kcondon)
Original Date: 2014-04-14T19:19:32Z


This is related to indexing not enforcing hierarchy, see ticket 3464.

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-04-24T19:09:01Z


Kevin Condon wrote:

not allow children to be published if parent is unpublished.

The above is the decision we're going with, it sounds like. From discussion over email:

Phil:

Right, it makes no sense that the toggle is flipped to "Published" but
we see the root dataverse is still "Private".

How strange! How did we get into this state?

Well, we currently don't enforce any rules regarding making dataverses
public. Dataverse creators can simply flip their dataverse to public
whenever they want. This makes the dataverse discoverable **even if
the parent dataverse is not public**.

This needs to change, as you've pointed out. We should never make a
dataverse discoverable and indexable by Google until the parent
dataverse is discoverable, right? The question is... what should we
do? I see two options:

1. Prevent users from making dataverses public until the parent
dataverse is public.

2. Introduce a new state for dataverses that dataverse creators can
use to indicate that they are *ready* to make their dataverse public
but provide enough messaging and notifications to let them know that
their dataverse won't actually become public until the parent
dataverse is public. Of course, they may have no control over the
parent dataverse... they might need to go nag the creator of the
parent dataverse about making it public. If we introduce this new
state, we should give it a name. Perhaps the three states could be
called Private, Ready, and Published. Maybe not "Ready"... "Pending
Publication"? I don't know.

I think I've convinced myself that option 1 is better. I suppose the
same rule could be enforced for datasets... Prevent users from
publishing a dataset until the parent dataverse is public.

Liz:

Phil and I had a chat about the issue of what if a user wants to publish their
dataverse put can’t because the parent dataverse hasn’t been published,
i.e.-Harvard Dataverse is unpublished, the admin for the CfA Dataverse wants to
publish the dataverse but can’t because Harvard Dataverse is unpublished. I’m
suggesting we add in a notification that is sent to the admin of the parent
dataverse letting them know a child dataverse has attempted to be published but
can’t due to the parent one being unpublished. We can have a message appear to
the user trying to publish the child dataverse to let them know a notification
has been sent to the parent dataverse admin so that user is aware of what is
happening and isn’t left to wonder, “well what do I do now?”

Gustavo:

Unpublished parent dataverse: when first seeing this, my initial thought was to just not allow you to
publish the child without the parent being released. I prefer this to having the user attempt to publish,
thinking they can, and then getting rejected.

However, this notion of sending a notification wouldn't work with that. unless we have it say something
like send notification saying you would like to publish.

The first part of this would be very straightforward, the 2nd should not be that much additional work,
but at a point when we're trying to get it out, I'd like to know a suggested priority.

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Steve Kraffmiller (@sekmiller)
Original Date: 2014-04-28T18:19:29Z


With today's check-in DVs and Datasets that are owned by unpublished data verses will not be allowed to be published. This fix, of course, does not fix any prior dvd/datasets that were published under the prior non-existent rules.

To test need a new build after 2PM 4/28

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Kevin Condon (@kcondon)
Original Date: 2014-04-28T19:30:44Z


Tested on 4/28

Looks good, cannot publish a child until the parent is published.

Closing ticket

@eaquigley eaquigley added this to the Dataverse 4.0: Beta 1 milestone Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
Development

No branches or pull requests

2 participants