Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Dataverse: HTML in description can cause page layout /float issues. #2114

Closed
kcondon opened this issue Apr 29, 2015 · 3 comments
Closed
Assignees
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@kcondon
Copy link
Contributor

kcondon commented Apr 29, 2015

Specific use case: FF browser for the 1.2 Meter CO Survey Dataverse. Dataverse/Datasets/Files facets appear to right of description rather than below it.

screen shot 2015-08-27 at 2 13 10 pm

@kcondon kcondon added UX & UI: Design This issue needs input on the design of the UI and from the product owner Priority: Medium Type: Bug a defect labels Apr 29, 2015
@kcondon kcondon added this to the In Review - Short Term milestone Apr 29, 2015
@mheppler
Copy link
Contributor

Just doing a quick look at the description and it's HTML, it appears that the align="left" attribute and property of the image is what is causing the layout issue.

There is already an open issue for HTML that we should support in our metadata fields #1320 (Priority: High, Milestone: In Review). This specific issue in this ticket can be resolved one of the following ways:

  • A.) The layout of the dataverse page can be fixed to avoid layout issues like this in the future.
  • B.) The HTML that is allowed in metadata fields can be restricted using a white-list, as is suggested in Metadata Fields: Support HTML Tags #1320.
  • C.) The dataverse admin (or a Dataverse Support team member) can edit the HTML to fix this layout issue. (This would be easier on the user if there was a "preview" feature to the description field.)

What probably needs to happen is all three of these options, and a whole lot of testing on the kind of HTML being used in these kind of metadata fields in production.

mheppler added a commit that referenced this issue Aug 27, 2015
… element, to fix an align/float issue with HTML in the description. [ref #2114]
@mheppler
Copy link
Contributor

Added a "clearfix" element under the dataverse description containing element, to fix an align/float issue with HTML in the description.

Moving the above comment to issue #1320 to look into how the align attribute will be handled in the HTML validation on the description field.

screen shot 2015-08-27 at 2 29 44 pm

@mheppler mheppler modified the milestones: 4.2, In Review Aug 27, 2015
@mheppler mheppler assigned kcondon and unassigned mheppler Aug 27, 2015
@kcondon
Copy link
Contributor Author

kcondon commented Sep 3, 2015

OK, the last change made FF behave the same as Chrome, closing.

@kcondon kcondon closed this as completed Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

2 participants