Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer: Make Copyright Date Dynamic #2905

Closed
eaquigley opened this issue Feb 2, 2016 · 8 comments
Closed

Footer: Make Copyright Date Dynamic #2905

eaquigley opened this issue Feb 2, 2016 · 8 comments
Assignees
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@eaquigley
Copy link
Contributor

eaquigley commented Feb 2, 2016

Noticed today the copyright date in the footer is still 2015. Need to make this dynamic so we don't have to remember each year to update it.

@eaquigley eaquigley added UX & UI: Design This issue needs input on the design of the UI and from the product owner Type: Bug a defect labels Feb 2, 2016
@mheppler
Copy link
Contributor

mheppler commented Feb 2, 2016

Found a JSF-related suggested solution on Stack Overflow.

pdurbin added a commit that referenced this issue Feb 9, 2016
@pdurbin
Copy link
Member

pdurbin commented Feb 9, 2016

Note that the year is also hard-coded in the Sphinx docs. See f37fdbd as an example of where I updated it from 2015 to 2016 manually for now.

@pdurbin
Copy link
Member

pdurbin commented Sep 27, 2016

I put a fix in pull request #3380 (3379-custom-footer-copyright branch). I suppose to test this you would set the time on the server to a different year.

In https://waffle.io/IQSS/dataverse I moved this to QA. I added the 4.5.1 milestone per #3379 (comment)

@mheppler
Copy link
Contributor

Discussed with @pdurbin and @djbrooke on moving the dynamic copyright features developed as part of #3379 into this issue, and keeping it in QA for 4.5.1.

Then, #3379 will remain open for a later release, so that we can gather additional input from other installations on how they'd like to further customize the footer with custom text, images, layout, etc.

@pdurbin pdurbin assigned kcondon and unassigned pdurbin Sep 28, 2016
@kcondon
Copy link
Contributor

kcondon commented Sep 28, 2016

Discussed scope with Phil:

  1. the date should be dynamic and 2) you can change the text from “Harvard etc” to whatever you want.

@kcondon
Copy link
Contributor

kcondon commented Sep 28, 2016

so basic testing worked fine, including changing date
did notice some slowness when first loading pages but hope it had nothing to do with this

@pdurbin pdurbin assigned pdurbin and unassigned kcondon Sep 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Sep 28, 2016

@scolapasta and I decide it should say "Copyright © [YYYY]" by default and we'll let people add , The President & Fellows of Harvard College or whatever as a config option. This will help resolved the "For performance use settingsWrapper.get" issue I mentioned at #3379 (comment)

I'll update the branch/pull request (#3380).

@pdurbin
Copy link
Member

pdurbin commented Sep 29, 2016

In d78a834 I pushed the fix that @scolapasta and I talked about. Please see the updated Installation Guide in pull request #3380 for the new behavior. I also addressed the performance issue and am now using settingsWrapper.get. In a nutshell:

  • The out of the box behavior is now just "Copyright © [YYYY]" (nothing about Harvard)
  • You can use the new :FooterCopyright setting to add additional text.

At https://waffle.io/IQSS/dataverse I moved this to QA.

@pdurbin pdurbin removed their assignment Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

4 participants