-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shibboleth: Review Text For Converting an Account/Creating an Account #2950
Comments
New text for the two screens shown above!
@mcrosas you had an interest in this text so commenting at you to review @mheppler I'll need your assistance with adding this text in |
@eaquigley agree with the proposed changes. |
@mheppler I'll write up some updated text for the blue info box in the first screenshot and add it to this ticket. missed that my previous go around. |
Cleaned up layout of the Shib and Account Information pgs and updated help/info/validation messages. Here is a detailed breakdown of those changes. loginpage, shibb enabled
shib
dataverseuser, view + edit account information
termsofuse
Passing back to @pdurbin to looking into: shib
|
@mheppler I'm passing this back to you because I deploy the latest (204831d) to https://shibtest.dataverse.org and now it ain't right: To make that shib login block appear in your dev environment please run this...
... per http://guides.dataverse.org/en/4.2.4/installation/shibboleth.html#enable-shibboleth (I should add this to http://guides.dataverse.org/en/4.2.4/developers/dev-environment.html#shibboleth .) |
Fixed HTML rendering issue with help text in Institution Log In block on Log In pg. |
@mheppler lookin' good. Thanks. I just deployed aa5391a to https://shibtest.dataverse.org |
I've deployed f901d9f to https://shibtest.dataverse.org and now plan to vet all the changes @mheppler mentioned at #2950 (comment) . |
I believe this is a reversal of an earlier design decision but @mheppler said it should be removed so I'm removing it: #2950 (comment)
@mheppler I found a little bug where affiliation was not being displayed for Shib users so I fixed this in 66c4777.
As I mentioned in person, I think we displayed "Affiliation not provided by institution log in" for a reason, that it was a design decision, but I can't find anything backing this up so I removed it in 58ed4f8 . The point of having that text in there is that we are relying on the affiliation coming from the Identity Provider (IdP) but I can understand if users don't care about that. That text is only seen during the create/convert workflow anyway. I deployed the latest to https://shibtest.dataverse.org if @eaquigley or others want to check out the revised messages this issue is about. I believe we're done code-wise for this issue. I still need to write a summary for QA. |
Passing to QA. Mostly my role in this issue was to make sure no regressions were introduced as text was changed. @eaquigley and @mheppler defined what the text should actually say. The changes are in pull request #3025. |
@mheppler @eaquigley Can I close this? Hard for me to validate based on comments. |
@kcondon Looks good to me. Thanks! Closing ticket. |
The text was updated successfully, but these errors were encountered: