Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shibboleth: Review Text For Converting an Account/Creating an Account #2950

Closed
2 tasks
eaquigley opened this issue Feb 12, 2016 · 12 comments
Closed
2 tasks
Assignees
Labels
Feature: Account & User Info UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@eaquigley
Copy link
Contributor

  • Review, and if necessary change, text on Create Account + Terms of Use page to only be Agree to Terms of Use

screen shot 2016-02-23 at 3 03 58 pm

  • Review, and if necessary change, text on Welcome, Me, Myself, and I text; Success Message for converting account (what does this mean to the user? rather than what has happened in the back end)

screen shot 2016-02-23 at 3 41 29 pm

@eaquigley eaquigley added UX & UI: Design This issue needs input on the design of the UI and from the product owner Feature: Account & User Info labels Feb 12, 2016
@eaquigley eaquigley self-assigned this Feb 12, 2016
@eaquigley
Copy link
Contributor Author

New text for the two screens shown above!

  • Accept Terms and Create Account page:
    • For consistency, it should be Create Account which is what is on the Sign Up page under all the fields. Users are accepting terms by clicking on the checkbox
    • {Need help/info text from Liz to replace "Account Information – Please agree to the Dataverse Terms of Use to create your account."}--@mheppler here is my proposed text, "Account Information--This information is provided by your institution and will be used to create your Dataverse account."
    • {Need to determine if we want to display text "Affiliation not provided by institution log in" if no value is passed from institution for the Affiliation field}--@mheppler, if it isn't provided why don't we render it out so it doesn't show? That is our standard for missing metadata.
  • Welcome page:
    • Question: why is email not displayed as it is in the other workflow?
    • Change to be: Your institutional log in matches an email address already being used for a Dataverse account. By entering your current Dataverse password below, your existing Dataverse account can be converted to use your institutional log in.
    • Change button to be: Convert Account

@mcrosas you had an interest in this text so commenting at you to review

@mheppler I'll need your assistance with adding this text in

@mercecrosas
Copy link
Member

@eaquigley agree with the proposed changes.

@eaquigley
Copy link
Contributor Author

@mheppler I'll write up some updated text for the blue info box in the first screenshot and add it to this ticket. missed that my previous go around.

mheppler added a commit that referenced this issue Feb 24, 2016
@mheppler
Copy link
Contributor

Cleaned up layout of the Shib and Account Information pgs and updated help/info/validation messages.

Here is a detailed breakdown of those changes.

loginpage, shibb enabled

  • Added "Leaving your institution?..." text with "Dataverse Support" link to shibb login block

shib

  • Removed "Accept Terms and" from "Create Account" and "Convert Account" action buttons
  • Updated "Welcome..." help/info message
  • Updated "Account Information" help/info message for create account workflow
  • Styled "passwordRejected" validation error message
  • Added email to "Welcome..." convert account pg

dataverseuser, view + edit account information

  • Cleaned up layout by removing unnecessary style classes and ui:fragment components
  • Added "Account Information" tab header to bundle

termsofuse

  • Cleaned up layout by removing unnecessary style class

Passing back to @pdurbin to looking into:

shib

  • Add empty render logic to Affiliation form-group so that we don't have to display the "Affiliation not provided by institution log in" message

@mheppler mheppler assigned pdurbin and unassigned eaquigley Feb 24, 2016
@pdurbin
Copy link
Member

pdurbin commented Feb 25, 2016

Added "Leaving your institution?..." text with "Dataverse Support" link to shibb login block

@mheppler I'm passing this back to you because I deploy the latest (204831d) to https://shibtest.dataverse.org and now it ain't right:

log_in_-root_dataverse-_2016-02-25_14 10 21

To make that shib login block appear in your dev environment please run this...

curl -X PUT -d true http://localhost:8080/api/admin/settings/:ShibEnabled

... per http://guides.dataverse.org/en/4.2.4/installation/shibboleth.html#enable-shibboleth (I should add this to http://guides.dataverse.org/en/4.2.4/developers/dev-environment.html#shibboleth .)

@mheppler
Copy link
Contributor

Fixed HTML rendering issue with help text in Institution Log In block on Log In pg.

@mheppler mheppler assigned pdurbin and unassigned mheppler Feb 25, 2016
@pdurbin
Copy link
Member

pdurbin commented Feb 25, 2016

@mheppler lookin' good. Thanks. I just deployed aa5391a to https://shibtest.dataverse.org

@pdurbin
Copy link
Member

pdurbin commented Mar 3, 2016

I've deployed f901d9f to https://shibtest.dataverse.org and now plan to vet all the changes @mheppler mentioned at #2950 (comment) .

pdurbin added a commit that referenced this issue Mar 3, 2016
I believe this is a reversal of an earlier design decision but
@mheppler said it should be removed so I'm removing it:

#2950 (comment)
@pdurbin
Copy link
Member

pdurbin commented Mar 3, 2016

@mheppler I found a little bug where affiliation was not being displayed for Shib users so I fixed this in 66c4777.

Add empty render logic to Affiliation form-group so that we don't have to display the "Affiliation not provided by institution log in" message

As I mentioned in person, I think we displayed "Affiliation not provided by institution log in" for a reason, that it was a design decision, but I can't find anything backing this up so I removed it in 58ed4f8 . The point of having that text in there is that we are relying on the affiliation coming from the Identity Provider (IdP) but I can understand if users don't care about that. That text is only seen during the create/convert workflow anyway.

I deployed the latest to https://shibtest.dataverse.org if @eaquigley or others want to check out the revised messages this issue is about. I believe we're done code-wise for this issue. I still need to write a summary for QA.

@pdurbin
Copy link
Member

pdurbin commented Mar 18, 2016

Passing to QA. Mostly my role in this issue was to make sure no regressions were introduced as text was changed. @eaquigley and @mheppler defined what the text should actually say. The changes are in pull request #3025.

@pdurbin pdurbin assigned kcondon and unassigned pdurbin Mar 18, 2016
@kcondon
Copy link
Contributor

kcondon commented Mar 29, 2016

@mheppler @eaquigley Can I close this? Hard for me to validate based on comments.

@eaquigley
Copy link
Contributor Author

@kcondon Looks good to me. Thanks! Closing ticket.

@pdurbin pdurbin added this to the 4.4 milestone Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Account & User Info UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants