Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation Guide: Improve Shibboleth documentation #2953

Closed
6 of 7 tasks
pdurbin opened this issue Feb 12, 2016 · 9 comments
Closed
6 of 7 tasks

Installation Guide: Improve Shibboleth documentation #2953

pdurbin opened this issue Feb 12, 2016 · 9 comments
Assignees
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Feb 12, 2016

http://guides.dataverse.org/en/latest/installation/shibboleth.html should be reviewed. We won't remove "experimental" until #2117 is closed as explained at #2939.

At minimum we need to make the following changes:

After #2838 has gone through QA:

This effort should be coordinated with adding Shibboleth to the User Guide in #2975.

@pdurbin pdurbin self-assigned this Feb 12, 2016
@pdurbin pdurbin changed the title Shibboleth: Review documentation in Installation Guide Installation Guide: Improve Shibboleth documentation Mar 3, 2016
pdurbin added a commit that referenced this issue Mar 8, 2016
- Documente API to migrate Shib user to local #2915.
- Add Debugging section for #2916.
- Document identity federation stuff #2937.
- Reference :AllowSignup as part of "remote only" #2838.
@pdurbin
Copy link
Member Author

pdurbin commented Mar 8, 2016

In 21bd0e8 I improved the Shibboleth section of the Installation Guide and the change can be previewed at http://guides.dataverse.org/en/2939-shib/installation/shibboleth.html

@bencomp
Copy link
Contributor

bencomp commented Mar 10, 2016

As mentioned on IRC, I read the guide. One suggestion I have is that the part about converting local accounts to remote accounts is really aimed at end users and would better fit in the user guide.

@pdurbin
Copy link
Member Author

pdurbin commented Mar 10, 2016

@bencomp well, I half agree with you. :) ... converting from local to Shib is done by end users. We have a whole GUI and workflow that was developed mostly in #796. Converting from Shib to local is not done by end users. There's no GUI and an the API developed in #2915 is expected to be called with curl on localhost by a sysadmin. @eaquigley is working on updating the User Guide as part of #2975 so let's see what lands in the branch and see how much is added having to do with account conversion.

@pdurbin
Copy link
Member Author

pdurbin commented Mar 18, 2016

Passing to QA. I did a fairly significant rewrite of http://guides.dataverse.org/en/2939-shib/installation/shibboleth.html so the whole page should be reviewed to ensure it makes sense. This is part of pull request #3025.

@kcondon
Copy link
Contributor

kcondon commented Mar 25, 2016

Reviewed doc, changes mentioned above are in place.
Comments:
minor typo:
-Under Install Apache, change "made" to "make" in "we can made use of the mod_shib"
minor wording change needed:
-Under Institution-wide Shib Groups, change "put" to "include":
"an “institution-wide Shibboleth group” with https://idp.testshib.org/idp/shibboleth as the IdP would put everyone who logs in via the TestShib IdP mentioned above."
possible clarification:
under Configure Apache, an experienced system admin would probably make sense of it but what changes need to be made to which files?
conf.d reads any file ending in .conf, so:
-should the enforce https part say download and rename the sample file to dataverse.conf?
-for the Edit Apache Config files part, do those settings need to go into a particular Virtual Host section? I ask because on our local config it's not even in a virtual host section and it is working. Is that just a scoping issue? Explaining this aspect of apache config files may be out of scope but wanted to mention it.

Passing back to Phil for the last part, removing experimental, when ready.

pdurbin added a commit that referenced this issue Mar 28, 2016
- fixed typos
- consistently use "dataverse.example.edu"
- re-write Apache config section
@pdurbin
Copy link
Member Author

pdurbin commented Mar 28, 2016

@kcondon in 4d332e0 I fixed those typos (thanks!) and re-wrote the section on configuring Apache. Part of the confusion, I think, is that I hadn't completely switched over to using "dataverse.example.edu" in all the examples so I'm using that everywhere now (formerly, I was also using shibtest.dataverse.org and demo.dataverse.org). I hope this helps. I just ran a build so you can see the changes at http://guides.dataverse.org/en/2939-shib/installation/shibboleth.html

@pdurbin pdurbin assigned kcondon and unassigned pdurbin Mar 28, 2016
@kcondon kcondon assigned pdurbin and unassigned kcondon Mar 28, 2016
@kcondon
Copy link
Contributor

kcondon commented Mar 28, 2016

OK, all issues are fixed. Passing back to Phil to update when experimental is removed.

@pdurbin
Copy link
Member Author

pdurbin commented Mar 28, 2016

@kcondon I don't plan to remove "experimental" until we've run Shibboleth in production at https://dataverse.harvard.edu for a while. When I do remove "experimental" I plan to tag the commit with #2117 and put that issue (#2117) through QA. I'll pass this back to you to close or let me know if you don't like this plan. Thanks.

@pdurbin pdurbin assigned kcondon and unassigned pdurbin Mar 28, 2016
@kcondon
Copy link
Contributor

kcondon commented Mar 29, 2016

Closing

@kcondon kcondon closed this as completed Mar 29, 2016
@pdurbin pdurbin added this to the 4.4 milestone Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants