Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: Welcome to 4.0 Notification Needs to Change #2966

Closed
eaquigley opened this issue Feb 23, 2016 · 11 comments
Closed

Notifications: Welcome to 4.0 Notification Needs to Change #2966

eaquigley opened this issue Feb 23, 2016 · 11 comments
Assignees
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@eaquigley
Copy link
Contributor

Line 218 in the bundle says: "Welcome to Dataverse 4.0! Please take a look around, try everything out, and contact support@dataverse.org if you have questions or feedback."

Need to update this to not say 4.0. Also, I'm guessing we should take out support@dataverse.org as that is quite specific to the Harvard Dataverse and not what other installations will want.

@eaquigley eaquigley added UX & UI: Design This issue needs input on the design of the UI and from the product owner Type: Bug a defect labels Feb 23, 2016
@eaquigley eaquigley self-assigned this Feb 23, 2016
eaquigley added a commit that referenced this issue Feb 23, 2016
@posixeleni
Copy link
Contributor

Hope I am speaking in the right place. I also wanted to add that the Signature should be editable as well since @shlake reported to me that she was not able to edit that part of the notification letters. It says "Dataverse Project"

@pdurbin
Copy link
Member

pdurbin commented Feb 26, 2016

I'm guessing we should take out support@dataverse.org as that is quite specific to the Harvard Dataverse and not what other installations will want.

Yes, let's please use the system email instead.

Given that and Eleni's requirement, this issue needs to be assigned to a developer.

@eaquigley
Copy link
Contributor Author

Passing to @mheppler to update it to be the link to the support form pop up instead of an email address.

@mheppler
Copy link
Contributor

Reviewed with @eaquigley and have come up with new notification messages related to creating an account, both that display in the Notifications tab on the Account pg, and that get emailed to the user.

Welcome to {dataverseServiceBean.findRootDataverse().name} Dataverse! Get started by adding or finding data. Have questions? Check out the <a href="{systemConfig.guidesBaseUrl}/{systemConfig.version}/user/index.html" title="{dataverseServiceBean.findRootDataverse().name} Dataverse User Guide" target="_blank">User Guide</a> or contact <a href="#" onclick="event.preventDefault();PF('contactForm').show();" title=”Contact {dataverseServiceBean.findRootDataverse().name} Dataverse Support”>Dataverse Support</a> for assistance.

Welcome to Dataverse! Get started by adding or finding data. Have questions? Check out the User Guide at {systemConfig.getGuidesBaseUrl()}/{systemConfig.getVersion()}/user/ or contact Dataverse Support for assistance.

@mheppler
Copy link
Contributor

Updated welcome/create account-related app/email notifications.

Pushed this code to the 2966-4.0notification branch.

mheppler added a commit that referenced this issue Feb 26, 2016
… the backing bean and breaking when displayed in the browser. [ref #2966]
@mheppler
Copy link
Contributor

Passing this to QA and submitting a pull request.

@posixeleni -- regarding your question, let's review this in more detail when you return to the office. If I am understanding it correctly, the notification.email.closing signature can be edited in Bundle.properties. If there are any other outstanding issues related to that which we need to address, we can open a new issue specific to those.

@mheppler
Copy link
Contributor

Page/Requirements Issue# Commit#
Account Pg Notification, Create Account
Change notification msg to open Contact Dataverse Support popup, improve text in general #2966 4e44d10, 421f821
Email Notification, Create Account
Change notification msg to not include '4.0' or 'support@dataverse.org', to improve text in general, and add dynamic (installation/version) link to User Guide #2966 f35995a, 4e44d10

scolapasta added a commit that referenced this issue Feb 26, 2016
#2966 Update "Welcome..."/create account-related notifications
@kcondon
Copy link
Contributor

kcondon commented Apr 19, 2016

I believe this pull request is being held up by other issues in the request so have not yet tested.

@pdurbin
Copy link
Member

pdurbin commented Apr 19, 2016

4e44d10 introduced the regression at #3036 so I'm probably going to revert it.

@pdurbin
Copy link
Member

pdurbin commented Apr 19, 2016

@kcondon as I mentioned I'm putting this issue in the 4.4 milestone since that's the milestone for this issue where I just left a detailed comment: #3036 (comment)

Also, per your request I just listed this issue in pull request #3025.

@kcondon
Copy link
Contributor

kcondon commented Apr 19, 2016

OK, looks good, closing.

@kcondon kcondon closed this as completed Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants