Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API should return proper HTTP codes #298

Closed
eaquigley opened this issue Jul 9, 2014 · 8 comments
Closed

API should return proper HTTP codes #298

eaquigley opened this issue Jul 9, 2014 · 8 comments
Assignees
Labels

Comments

@eaquigley
Copy link
Contributor


Author Name: Michael Bar-Sinai (@michbarsinai)
Original Redmine Issue: 3712, https://redmine.hmdc.harvard.edu/issues/3712
Original Date: 2014-03-14
Original Assignee: Gustavo Durand


API endpoints:

NOT converted yet

  • Access
  • Browse (what's that?)
  • Config
  • DatasetFieldServiceApi
  • index
  • mail
  • meta
  • Search
  • SearchFields

Converted

  • Dataverses
  • Users
  • roles
  • permissions
  • Metadatablocks
  • Datasets

Deleted

  • Files

Redmine related issue(s): 3385


@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Michael Bar-Sinai (@michbarsinai)
Original Date: 2014-04-09T16:11:18Z


At least for new API methods: use the okResponse(XX) from AbstractApiBean

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Michael Bar-Sinai (@michbarsinai)
Original Date: 2014-06-04T19:11:35Z


Moving card to Gustavo, as Michael's API beans are converted.

@eaquigley eaquigley added this to the Dataverse 4.0: In Review milestone Jul 9, 2014
@eaquigley eaquigley mentioned this issue Jul 9, 2014
@scolapasta scolapasta assigned pdurbin and unassigned scolapasta Jul 11, 2014
@eaquigley eaquigley modified the milestones: Dataverse 4.0: Beta 4, Dataverse 4.0: In Review Jul 15, 2014
@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2014

The main reason I have this ticket is that we'd like to remove some unused API classes. See also #26.

@eaquigley eaquigley modified the milestones: Beta 4 - Dataverse 4.0, Beta 7 - Dataverse 4.0 Aug 15, 2014
@pdurbin pdurbin modified the milestones: Beta 7 - Dataverse 4.0, In Review - Dataverse 4.0 Aug 19, 2014
@pdurbin
Copy link
Member

pdurbin commented Sep 8, 2014

pdurbin added a commit that referenced this issue Nov 4, 2014
@scolapasta scolapasta modified the milestones: Dataverse 4.0: Final, In Review - Dataverse 4.0 Jan 6, 2015
@scolapasta scolapasta modified the milestones: Dataverse 4.0: Final, TEMP, In Review - Dataverse 4.0, Beta 13 - Dataverse 4.0 Jan 23, 2015
@scolapasta scolapasta removed this from the Beta 13 - Dataverse 4.0 milestone Feb 6, 2015
@scolapasta scolapasta modified the milestones: In Review - Dataverse 4.0, Beta 13 - Dataverse 4.0, Beta 15 - Dataverse 4.0 Feb 6, 2015
pdurbin added a commit that referenced this issue Feb 25, 2015
@scolapasta scolapasta assigned michbarsinai and unassigned pdurbin Mar 2, 2015
@michbarsinai
Copy link
Member

To be converted:

  • Access - DONE
  • Browse (what's that?) - Deleted
  • Config - DONE
  • DatasetFieldServiceApi - DONE
  • index - DONE
  • mail - done
  • meta - Leo contacted
  • Search - DONE
  • SearchFields - DELETED

@michbarsinai
Copy link
Member

Current state: Meta is the only one left.

@pdurbin
Copy link
Member

pdurbin commented Mar 3, 2015

@michbarsinai sorry but as I mentioned in 7cde601 I'm not ready to change from String to Response in api/Config.java

@michbarsinai
Copy link
Member

Current state:
apiConfig has to stay as is for now.
meta will probably be merged to Access. At any event, can't change until TowRavens are updated as well.

Assign to @scolapasta - this can be closed, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants