-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shibboleth UI Improvements: Messaging, Formatting, Etc #3085
Comments
@eaquigley I added an |
@pdurbin I actually think to make it flow the same as Institutional Log In it should be Dataverse Account Log In. @mcrosas what do you think? |
@eaquigley @mcrosas in c979314 I changed it to "Dataverse Account Log In"... ... but please note that at #3085 (comment) above I'm not talking about the order of the words. I think having the word "local" helps clarify the non-Shibboleth option. In my view, even if you log in via Shibboleth you still have a Dataverse account. The guides at http://guides.dataverse.org/en/2939-shib/user/account.html even say "How to create a new Dataverse account using Institutional Log In." So Shibboleth users have Dataverse accounts. I don't feel super strongly about all this but enough to write what I've written in this issue I guess. Just some food for thought. Again, I'm influenced mostly by https://discovery.refeds.org/demo/good/step-two/ Interestingly, Trello says to log in via email or username and StackOverflow says to log in via email. Neither uses the word "local": |
@pdurbin, I agree with @mcrosas about local being too internal. The example you mention, to me, is highlighting the importance of having two distinct different areas for logging in via built in or authenticated user, not the language used for the sections. |
Since both @mcrosas and @eaquigley are happy with the text above the local login (again, I don't care that much 😄 ) and because I just created a new separate issue for the ugly dropdown (#3091), I'm moving this issue into QA. Things to test: Create Account Workflow
Convert Account Workflow
The changes are in pull request #3025. |
Works, closing. |
From today's review with @mcrosas and me:
Log In Page:
Create Account Workflow
Convert Account Workflow:
Assigning to @pdurbin to do a first run through of what he can fix before passing to @mheppler to work on any remaining items.
The text was updated successfully, but these errors were encountered: