Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets: Conditional display of "Producer" or "Distributor" text #3180

Closed
djbrooke opened this issue Jun 22, 2016 · 8 comments
Closed

Widgets: Conditional display of "Producer" or "Distributor" text #3180

djbrooke opened this issue Jun 22, 2016 · 8 comments
Assignees
Milestone

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Jun 22, 2016

If a Dataset specifies ONLY ONE metadata field of type URL:
e.g.

  • Producer URL
  • Distributor URL

then the Dataset Citation widget will NOT display the respective title of the field in the widget and will only display "URL"

If a Dataset specifies multiple metadata fields of type URL:

then the Dataset Citation widget will display the display name of the field, e.g. "Producer URL" along with the specific URL.

@djbrooke
Copy link
Contributor Author

@scolapasta - feel free to edit this one up if it does not reflect the desired changes!

@djbrooke djbrooke added this to the 4.4 milestone Jun 22, 2016
@kcondon
Copy link
Contributor

kcondon commented Jun 23, 2016

@djbrooke I was not aware of the second requirement regarding multiple citation field URL labels.
@scolapasta Did you code for the multiple citation URL case?

@scolapasta
Copy link
Contributor

Yes, it checks count of URLs and only substitutes the name if there is only one URL.

@kcondon
Copy link
Contributor

kcondon commented Jun 23, 2016

Yes, verified with 1, 2, and 3 different url fields. Waiting final tweak, passing back to Gustavo to fix generalization issue.

@pdurbin
Copy link
Member

pdurbin commented Jun 28, 2016

In e62d5a2 I updated the Solr schema for the alternativeURL field added in e10ab1e but I thought I'd mention that it seems a little strange to me that this field appears even above "title" when updating metadata:

screen shot 2016-06-28 at 1 56 48 pm

Also in in e10ab1e the tsv was edited directly rather than applying to change first to what I thought was the source of truth for the citation metadata block, the spreadsheet tab at https://docs.google.com/spreadsheet/ccc?key=0AjeLxEN77UZodHFEWGpoa19ia3pldEFyVFR0aFVGa0E#gid=0 linked from http://guides.dataverse.org/en/4.3.1/user/appendix.html#metadata-references . If we are abandoning those spreadsheet tabs as the source of truth for our metadata blocks we should stop linking to them from the User Guide. #3168 is related.

A side note is that the way I update the Solr schema is by loading all the metadata blocks, running curl http://localhost:8080/api/admin/index/solr/schema >> conf/solr/4.6.0/schema.xml and then editing schema.xml by hand to update the two sections (field and copyField), replacing the content that was there with the content that was in the script. For now this process is documented at the top of https://github.com/IQSS/dataverse/blob/v4.3.1/src/main/java/edu/harvard/iq/dataverse/search/SearchFields.java

@scolapasta
Copy link
Contributor

That location was the first suggested location from @mcrosas but after further review (seeing it here) we moved it between alternativeTitle and OtherId.

@scolapasta
Copy link
Contributor

Also, I went ahead and updated that doc with this new field; however I don't think it has been kept up to date for other changes. (For example, these were removed: contributorAffiliation, contributorIdentifierScheme, contributorIdentifier, but are still there)

These changes are from before, and outside the scope of this issues.

@kcondon
Copy link
Contributor

kcondon commented Jun 28, 2016

Works! Closing.

@kcondon kcondon closed this as completed Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants