Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin-Users API doc not clear how to specify user with JSON #3192

Closed
tomck opened this issue Jul 1, 2016 · 9 comments
Closed

Builtin-Users API doc not clear how to specify user with JSON #3192

tomck opened this issue Jul 1, 2016 · 9 comments

Comments

@tomck
Copy link
Contributor

tomck commented Jul 1, 2016

https://github.com/IQSS/dataverse/blob/develop/doc/sphinx-guides/source/api/native-api.rst

Generates a new user. Data about the user are posted via JSON. Note that the password is passed as a parameter in the query.

This information isn't very clear, creating issue per @pdurbin in IRC

@pdurbin
Copy link
Member

pdurbin commented Jul 1, 2016

@tomck thanks for creating this issue. http://guides.dataverse.org/en/4.4/installation/installation-main.html#superuser-account mentions dvinstall/data/user-admin.json and as of this writing it looks like this:

$ cat dvinstall/data/user-admin.json 
{
    "firstName":"Dataverse",
    "lastName":"Admin",
    "userName":"dataverseAdmin",
    "affiliation":"Dataverse.org",
    "position":"Admin",
    "email":"dataverse@mailinator.com"
}

This comes from https://github.com/IQSS/dataverse/blob/v4.4/scripts/api/data/user-admin.json and there are similar files in that directory.

I have some crazy scripts I use in testing here if they are of interest:

They operate on https://github.com/IQSS/dataverse/blob/v4.4/scripts/search/users.tsv

Probably too much information. 😄

I agree the API Guide should be made more clear.

@dlmurphy
Copy link
Contributor

Worked with @pameyer on this during the hackathon. We added a JSON example to help make this more clear.

@dlmurphy dlmurphy mentioned this issue Jun 14, 2017
@pdurbin
Copy link
Member

pdurbin commented Jun 15, 2017

@dlmurphy @pameyer in your pull request, don't forget to use the magic "connects to" syntax and advance the issue to code review in Waffle.

@pameyer
Copy link
Contributor

pameyer commented Jun 19, 2017

Connects to #3192

attempting the magical "connects to" in the issues (because it doesn't appear to be taking in the PR)"

@pdurbin
Copy link
Member

pdurbin commented Jun 19, 2017

@pameyer I could be wrong but I think the "connect to" needs to go in the description.

@pdurbin
Copy link
Member

pdurbin commented Jun 19, 2017

I tried to add some clarify in bffb3fe and moved this issue to Code Review at https://waffle.io/IQSS/dataverse

@pdurbin pdurbin removed their assignment Jun 19, 2017
dlmurphy added a commit that referenced this issue Jun 19, 2017
Fixed some typos under Builtin Users section of Native API page.
@dlmurphy
Copy link
Contributor

Fixed a few typos, moving to QA.

@pdurbin
Copy link
Member

pdurbin commented Jun 20, 2017

This was merged as part of pull request #3892.

@pdurbin pdurbin closed this as completed Jun 20, 2017
@pdurbin
Copy link
Member

pdurbin commented Jun 20, 2017

Whoops, I meant to say that the fix is in pull request #3920.

@pdurbin pdurbin reopened this Jun 20, 2017
@pdurbin pdurbin mentioned this issue Jun 20, 2017
5 tasks
@kcondon kcondon closed this as completed Jun 20, 2017
@djbrooke djbrooke added this to the 4.7 - Dashboard and Customization milestone Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants