Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a zip file on the fly using the new "directorylabel" field added in pull request #3412 #3448

Closed
bjonnh opened this issue Nov 2, 2016 · 5 comments
Labels
Feature: File Upload & Handling User Role: Guest Anyone using the system, even without an account

Comments

@bjonnh
Copy link

bjonnh commented Nov 2, 2016

This will depend on whether or not #3412 will be implemented.

That would allow the user to download the hierarchy in a zip file.

I also wonder if this would be possible using rsync.

This was called "Download as zip while preserving directory structure" in 3.6

@pdurbin
Copy link
Member

pdurbin commented Jun 8, 2017

Pull request #3412 was merged so this could, in theory, be implemented, but on upload of a zip we'd need to persist the directory structure. We don't do this right now.

This is feature we had in DVN 3.x. See "Download as zip while preserving directory structure" at "3.6 & 4.0 Feature Comparison" at https://docs.google.com/spreadsheets/d/1ftHM6E4b9Dft_AvA6KTzeklJyLguItz2_0hNAFL8-VM/edit?usp=sharing

@pdurbin pdurbin added the User Role: Guest Anyone using the system, even without an account label Jul 4, 2017
@pdurbin
Copy link
Member

pdurbin commented Dec 5, 2018

on upload of a zip we'd need to persist the directory structure. We don't do this right now.

Update! We're discussing file hierarchy (#2249) today and @landreev and I both independently verified that when you upload a zip file, the "directorylabel" column in the database is indeed populated.

Here's the file I uploaded:

data.zip

murphy:tmp pdurbin$ unzip data.zip 
Archive:  data.zip
   creating: folder1/
   creating: folder1/sub1/
 extracting: folder1/sub1/file.txt   
   creating: folder1/sub2/
 extracting: folder1/sub2/file.txt   
   creating: folder2/
   creating: folder2/sub1/
 extracting: folder2/sub1/file.txt   
   creating: folder2/sub2/
 extracting: folder2/sub2/file.txt   
murphy:tmp pdurbin$ 

And here's how it looks in the database:

screen shot 2018-12-05 at 3 16 40 pm

Here's how the files look in the GUI (I'm on Dataverse 4.9.4):

screen shot 2018-12-05 at 3 24 24 pm

@pdurbin
Copy link
Member

pdurbin commented Jan 30, 2019

@bjonnh does #5498 capture what you want?

@bjonnh
Copy link
Author

bjonnh commented Jan 30, 2019

Yes!

@pdurbin
Copy link
Member

pdurbin commented Jan 30, 2019

@bjonnh great! #5498 is now in our next sprint so are you ok with closing this issue as a duplicate?

@bjonnh bjonnh closed this as completed Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: File Upload & Handling User Role: Guest Anyone using the system, even without an account
Projects
None yet
Development

No branches or pull requests

2 participants