Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add directorylabel column to filemetadata table #3412

Merged
merged 13 commits into from
Oct 28, 2016

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Oct 19, 2016

RFI Checklist

1. Related Issues


2. Pull Request Checklist

  • Functionality completed as described in FRD (no FRD)
  • Dependencies, risks, assumptions in FRD addressed (no FRD)
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing) (SQL script added)
  • Documentation completed (N/A. Backend code.)
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

Connects to #3405.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 8.6% when pulling a509fca on 3405-filemetadata-directory-label into 8ad3431 on develop.

@pdurbin
Copy link
Member Author

pdurbin commented Oct 19, 2016

I just wanted to mention that in the course of testing this pull request I noticed a bug which I just opened at #3413 but I strongly believe that it's existing behavior in Dataverse 4.5 and 4.5.1 and not introduced by the code in this pull request.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 8.796% when pulling 903f4ff on 3405-filemetadata-directory-label into 8ad3431 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 8.796% when pulling 903f4ff on 3405-filemetadata-directory-label into 8ad3431 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 8.796% when pulling 8e4b749 on 3405-filemetadata-directory-label into 8ad3431 on develop.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Yes, moving these methods out of the EJB bean and into a static utility class is a great idea.

This lets us return a "bad request" rather than a 500 error.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 8.836% when pulling 4e59b22 on 3405-filemetadata-directory-label into 8ad3431 on develop.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants