-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add directorylabel column to filemetadata table #3412
Conversation
I just wanted to mention that in the course of testing this pull request I noticed a bug which I just opened at #3413 but I strongly believe that it's existing behavior in Dataverse 4.5 and 4.5.1 and not introduced by the code in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Yes, moving these methods out of the EJB bean and into a static utility class is a great idea.
This lets us return a "bad request" rather than a 500 error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
… (e.g., any file uploads via UI)
RFI Checklist
1. Related Issues
2. Pull Request Checklist
3. Review Checklist
After the pull request has been submitted, fill out this section.
Connects to #3405.