-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export/Harvesting: Leaving "Name" under "Contact" blank while creating a dataset results in no contact email address in the DDI export #3802
Comments
@philippconzett just noted at https://groups.google.com/d/msg/dataverse-community/v6jgyewGqlI/f7RKzoIdBAAJ the following:
In the testing above, I was using EZID, not DataCite, as my Maybe he's right. Maybe |
Thanks Phil. I just created an issue for the contact name problem: Best, |
This issue is better tracked at #3839. Closing. |
The two issues, this one and #3839, are related but different enough to be in different github issues. Each issue could be solved with different solutions. And from what I understand, one solution can solve both issues only if we decide that contactName is always filled out. In #3839, we talked about two ways to do this, either by:
I don't think any of those solutions solve what I think are the larger issues, the first of which is unique to #3839:
What I'm hoping to say is that solving the remaining open issue, #3839, may not solve this one. And details about this closed issue aren't in #3839. Solving this issue should involve making sure that contactEmail is included in all datasets' DDI XML even when a contactName is missing. |
Let's work on this when we get around to working on #3839. Meanwhile, I'm closing it. |
While investigating #3443 I noticed that if you don't fill in "Name" under "Contact" when creating a dataset, the email address of the dataset contact is not available in the DDI export. I expect to see
<contact email="philip_durbin@harvard.edu"></contact>
rather than nothing. I'm going to label this as a bug. The REST Assured XmlPath expression I test for iscodeBook.stdyDscr.stdyInfo.contact.@email
.Dataset with Contact Name left blank (email absent from DDI)
Dataset with Contact Name (email present in DDI)
Note that
<contact affiliation="Harvard University" email="philip_durbin@harvard.edu">Durbin, Philip</contact>
is highlighted below.I know what causes this and I added a TODO at
dataverse/src/main/java/edu/harvard/iq/dataverse/export/ddi/DdiExportUtil.java
Line 611 in 1a1b837
I showed this to @landreev and @sekmiller and we agreed that it's out of scope for #3443. We think the DDI spec will allow an empty element with just an attribute like
<contact email="philip_durbin@harvard.edu"></contact>
but there is an open question of if we can harvest this.The text was updated successfully, but these errors were encountered: