download all files does not download all files.

[smakonin]

Using my dataset (http://dx.doi.org/10.7910/DVN/FIE0S4) which has 88 files. Check the "all" checkbox and click the download button. Less than 88 files are downloaded. Sometimes on 20 and sometimes only 37.

All 88 file should be downloaded.

[pdurbin]

@smakonin thanks for the bug report. It looks like #3711 may be related.

[pdurbin]

@djbrooke and I discussed this issue yesterday during my one on one. We agreed that it sounds like a bug. Needs investigation.

[pdurbin]

We just had a nice discussion about this issue during backlog grooming today and it sounds like we're going to try an approach where if the user clicks the box under "88 files" in the screenshot below, we'll set some sort of "all" boolean in the backend and zip up all the files, regardless of what the PrimeFaces component shows as check or unchecked for each file. When we pick up issue I think we could close #3711 as a duplicate of this one.

Longer term #3404 enumerates a number of problems with how files are handled on the dataset page.

[sekmiller]

I have a partial fix due to the limitations of the Primefaces table component. In my fix, if a user clicks the "Select All" and then download, she will get all of the files downloaded. However if another user selects all then de-selects one or more files in the table, then downloads he will still get all of the files.

Is this an acceptable improvement?

[pdurbin]

I suspect the most common case is the user think, "Just let me download all the files and I'll sort them out on my laptop." That is to say, yes, I think this is an improvement.

[sekmiller]

Based on our Stand-up discussion I am moving to Code Review

[mheppler]

Fixed scrolling bug associated with CSS hack in previous scrolling bug fix (836d248).

I was attempting to add extra spacing to the bottom of the files table in order to display dropdown menus for the Download, Explore, Configure buttons. Unfortunately I added the space to the wrong containing element. This should now be fixed. See attached screenshot of Download button in the last row of the table -- and there is even a scroll bar displayed. Sorry @sekmiller.

[sekmiller]

In its final version, (at least for this ticket) if a user clicks the checkbox at the top of the table then clicks the Download button he will get all of the files. If after clicking the select all box the user has any other interaction with the table at the file level (unselect or select) before clicking the download button then they will only get the files physically selected in the table.

[kcondon]

Works except if in draft.