API tests are failing

[pdurbin]

API tests are failing as of 4.8 and 4.8.1:

• edu.harvard.iq.dataverse.api.DatasetsIT.testCreateDatasetWithDcmDependency
• edu.harvard.iq.dataverse.api.DatasetsIT.testDcmChecksumValidationMessages
• edu.harvard.iq.dataverse.api.InReviewWorkflowIT.testCuratorSendsCommentsToAuthor

Here's a screenshot:

That's from https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/142/testReport/

[pdurbin]

Since I'm already in InReviewWorkflowIT for #4139 anyway and it has a failing test, I plan to fix all the API tests in the 4139-curator-edits-in-review branch I just created locally (not pushed yet).

[pdurbin]

InReviewWorkflowIT.testCuratorSendsCommentsToAuthor

Fixed in d3125d5. As discussed with @sekmiller there was a FIXME I was also able to remove.

[pdurbin]

I changed my mind and created a new branch called 4189-fix-api-tests and created pull request #4199 for just the fixes for the API tests. Moving to code review.

[pdurbin]

https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/143/ is passing! Hooray!

[pdurbin]

DatasetsIT.testPrivateUrl started failing at https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/edu.harvard.iq$dataverse/145/testReport/junit/edu.harvard.iq.dataverse.api/DatasetsIT/testPrivateUrl/ as of 6b53fa1 and I'm hoping 3c8adc2 fixes it.

[kcondon]

I almost merged this, luckily I noticed it was the bigger pull request.

[pdurbin]

Good news. Now the pull request #4216 has been merged, all API tests are passing again:

That is to say, build 146 is blue rather than yellow: https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/