Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove html comments from builds #4281

Closed
matthew-a-dunlap opened this issue Nov 14, 2017 · 1 comment
Closed

Remove html comments from builds #4281

matthew-a-dunlap opened this issue Nov 14, 2017 · 1 comment

Comments

@matthew-a-dunlap
Copy link
Contributor

Right now there are many html comments in our xhtml pages, and those comments muck up our code in source view. We can add this chunk to our web.xml to remove the comments:

    <context-param>
        <param-name>facelets.SKIP_COMMENTS</param-name>
        <param-value>true</param-value>
    </context-param>

It looks like there is no downside, and if a developer needs the comments for debugging its easy to turn off.
@pdurbin
Copy link
Member

pdurbin commented Jun 28, 2018

Closing as a duplicate of #4351.

@pdurbin pdurbin closed this as completed Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdurbin @matthew-a-dunlap