Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up comments in displayed html #4351

Closed
matthew-a-dunlap opened this issue Dec 5, 2017 · 1 comment
Closed

Clean up comments in displayed html #4351

matthew-a-dunlap opened this issue Dec 5, 2017 · 1 comment
Assignees

Comments

@matthew-a-dunlap
Copy link
Contributor

Dataverse has a large number of HTML developer comments that are unsightly when looking at the source code. Furthermore, commented out render logic in our XHTML can lead to unforseen data being inserted into our webpages. Instead of using the ui:remove tag on each comment (which is inevitably forgotten), we can instead use this chunk in the web.xml to remove all comments.

<context-param> <param-name>javax.faces.FACELETS_SKIP_COMMENTS</param-name> <param-value>true</param-value> </context-param>

This can still be easily turned off by developers working on their local machines but will ensure that our production machines look good and are safer!

matthew-a-dunlap added a commit that referenced this issue Dec 5, 2017
@pdurbin
Copy link
Member

pdurbin commented Dec 5, 2017

6f1ef61 makes sense to me. I think you should go ahead and make a pull request, @matthew-a-dunlap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants