Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset page: Page fails to load when it cannot understand an image file to generate thumbnail #4473

Closed
kcondon opened this issue Feb 23, 2018 · 4 comments
Assignees

Comments

@kcondon
Copy link
Contributor

kcondon commented Feb 23, 2018

See RT 256006 for details but the dataset page failed to load when it tried to generate a thumbnail for a particular .tiff file but could not understand the format.

@landreev
Copy link
Contributor

Yep, happens in the ImageIO.read(...) line in ImageThumbConverter.java:

try {
            logger.fine("attempting to read the image file with ImageIO.read(InputStream), " + storageIO.getDataFile().getStorageIdentifier());
            fullSizeImage = ImageIO.read(inputStream);
        } catch (IOException ioex) {
            logger.warning("Caught exception attempting to read the image file with ImageIO.read(InputStream)");
            return false;
        }

I'm catching IOException there - but it looks like that weirdly-formatted TIFF is resulting in an IllegalArgumentException...
So yeah, annoying - but an easy fix.

@pdurbin
Copy link
Member

pdurbin commented Feb 26, 2018

@landreev thanks for posting the code. Sounds like a "1" to me. (The "size" in https://waffle.io/IQSS/dataverse for anyone who has no idea what I'm talking about.)

@landreev
Copy link
Contributor

landreev commented Mar 9, 2018

this was de-facto prioritized, since it was causing problems with some datasets in production. a PR is coming (it is about 1 yes).

@sekmiller
Copy link
Contributor

Ready for QA

@sekmiller sekmiller removed their assignment Mar 15, 2018
@kcondon kcondon self-assigned this Mar 15, 2018
kcondon added a commit that referenced this issue Mar 16, 2018
Relaxed exception handling in the thumbnail generator (#4473)
@kcondon kcondon closed this as completed Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants