Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup - better handling of external links #4717

Closed
pameyer opened this issue May 25, 2018 · 1 comment
Closed

Code Cleanup - better handling of external links #4717

pameyer opened this issue May 25, 2018 · 1 comment

Comments

@pameyer
Copy link
Contributor

pameyer commented May 25, 2018

Splitting out from #3337 (comment) :

Short version - it would probably be a good idea to add rel="noopener" to external links, in addition to target="blank".

Another thought that's almost certainly out of scope for this issue, but related to the discussion of consistency with handling external links, would be adding rel="noopener" to external links (recommended by lighthouse for performance / security - https://developers.google.com/web/tools/lighthouse/audits/noopener).

@mheppler mheppler changed the title as an end user browsing dataverse, I'd like sites opened in external links to not have access to the same javascript execution context as dataverse Code Cleanup - better handling of external links Sep 23, 2019
@mheppler
Copy link
Contributor

mheppler commented Oct 3, 2019

As @pdurbin noted in his PR comment, we have started to address this issue in adds rel="noopener" attribute to the link formatting in citation.tsv #6249. I will be diligent when reviewing PR that include UI changes which will provide an opportunity to add these rel="noopener" attribures.

I will start a checklist of the places it has been address here, so that if/when this issue gets picked up, we know where this is already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants