adds rel="noopener" attribute to the link formatting in citation.tsv #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…." link formatting provided in citation.tsv
|
Can one of the admins verify this patch? |
|
Yeah, looks good. This appears to be a partial solution for #4717. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed at the standup meeting this AM.
This adds one more attribute to the html formatting for external urls that we provide in
citation.tsv:<a href="#VALUE" target="_blank" rel="noopener">#VALUE</a>this is considered a better style/the recommended way, vs. just
target="_blank".(we've been meaning to add this for a while; and since we are recommending the installations to refresh the citation block in 4.17, could be a good time to do it now)