Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show draft file card if file has changed from published version #528

Closed
eaquigley opened this issue Jul 9, 2014 · 4 comments
Closed

Comments

@eaquigley
Copy link
Contributor


Author Name: Philip Durbin (@pdurbin)
Original Redmine Issue: 3943, https://redmine.hmdc.harvard.edu/issues/3943
Original Date: 2014-05-07
Original Assignee: Philip Durbin


In #3795 multiple cards for datasets and files were introduced:

  • published cards are discoverable by anonymous
  • draft cards are discoverable by the creator

We're concerned, however, that when you take a published dataset and edit it, draft cards are created for each file in the published study. This might be overwhelming.

With screenshots, here is a sample publishing workflow where a published file turns gets a draft card perhaps prematurely because the description of the file is not changed until later:


Related issue(s): #380
Redmine related issue(s): 3795


@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-05-07T17:25:08Z


I asked Leonid about this ticket, specifically:

Given a dataset with multiple versions...

...each dataset version has various files

...how easy is to know if a file has changed or not between dataset versions?

There is no simple value to check. It sounds like we need to either:

  • iterate through the various file metadata (label, description, etc.) and look for differences
  • compare timestamps? if they exist?

Something like that...

@eaquigley eaquigley added this to the Dataverse 4.0: In Review milestone Jul 9, 2014
@scolapasta scolapasta modified the milestones: Beta 4 - Dataverse 4.0, In Review - Dataverse 4.0 Jul 15, 2014
@pdurbin pdurbin modified the milestones: Beta 9 - Dataverse 4.0, In Review - Dataverse 4.0 Nov 12, 2014
@eaquigley eaquigley assigned eaquigley and unassigned pdurbin Nov 13, 2014
@eaquigley
Copy link
Contributor Author

@landreev I just came across this ticket again and was wondering if there is a way to check the timestamps for files as @pdurbin suggests in the comment above.

@eaquigley eaquigley assigned landreev and unassigned eaquigley Jan 14, 2015
@scolapasta scolapasta modified the milestones: Beta 11 - Dataverse 4.0, Dataverse 4.0: Final, TEMP, In Review - Dataverse 4.0 Jan 23, 2015
@scolapasta scolapasta modified the milestones: TEMP, Beta 12 - Dataverse 4.0, In Review - Dataverse 4.0 Jan 23, 2015
@landreev landreev assigned kcondon and unassigned landreev Feb 5, 2015
@landreev
Copy link
Contributor

landreev commented Feb 5, 2015

This should be working as requested now. When you create a new draft version of a published dataset, only the files that have been added and/or edited in the draft version will show up in search results, as extra result cards.
For example, in the dataset below, the file name of 12075.tab was modified in the draft version; so a draft search card is displayed, with the changed name. The file 120747.tab has not been modified at all since the released version; so there's only one search result card:
screen shot 2015-02-04 at 9 42 21 pm

@kcondon
Copy link
Contributor

kcondon commented Feb 6, 2015

OK, works as described, closing

@kcondon kcondon closed this as completed Feb 6, 2015
pdurbin added a commit that referenced this issue Aug 18, 2015
We'll need to make datasetVersionId searchable per #2038. It sure seems
like the rules about draft files established in #528 will have to
change. :/

Issue #2460 created about database deadlocks. :(

Issue #2464 created about having to edit metadata of a published dataset
before we can delete a file via SWORD. :(

Issue #2461 created about how the native API allows version less than
v1.0 to be published. :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants