Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2.0 - Microsoft #6155

Closed
alejandratenorio opened this issue Sep 10, 2019 · 3 comments · Fixed by #6192
Closed

OAuth 2.0 - Microsoft #6155

alejandratenorio opened this issue Sep 10, 2019 · 3 comments · Fixed by #6192

Comments

@alejandratenorio
Copy link
Contributor

With the current OAuth2 providers, we can only connect to specific providers. We worked with Active Directory and we had to connect with Microsoft.
Similar to ORCID, GOOGLE and GitHub, we integrate Mircrosoft as OAuth2 provider in Dataverse.
The goal of CIMMYT is to contribute with this. We would like to share with you the source code for your review and comments.

@pdurbin
Copy link
Member

pdurbin commented Sep 18, 2019

@alejandratenorio hi! Thanks for your interest in contributing to Dataverse!

I was just clicking around https://data.cimmyt.org and noticed that the Microsoft login makes use of an HTTP Basic Auth pop ("Authentication Required") as in the screenshots below:

Screen Shot 2019-09-18 at 11 01 15 AM
Screen Shot 2019-09-18 at 11 01 19 AM
Screen Shot 2019-09-18 at 11 01 50 AM

Was the HTTP Basic Auth popup a design choice? The other OAuth providers look more like this with the standard OAuth login flow (Google shown below):

Screen Shot 2019-09-18 at 11 05 33 AM

Screen Shot 2019-09-18 at 11 05 36 AM

Screen Shot 2019-09-18 at 11 05 47 AM

Please let us know. Thanks!

Also, I wanted to let you (and others) know that over at http://guides.dataverse.org/en/4.16/installation/shibboleth.html#shibboleth-and-adfs there are some instructions for logging into ADFS/Active Directory through Shibboleth/SAML instead of OAuth. I just mention this so that when it comes time to document the feature we can explain that there are multiple options (SAML and OAuth) for getting login to Microsoft working.

@alejandratenorio
Copy link
Contributor Author

Hello @pdurbin,

Basic Auth pop was a specific condition for CIMMYT, to limit log-in to email addresses ending in @cgiar.org.

Without the Basic Auth pop look like,

image

image

@pdurbin
Copy link
Member

pdurbin commented Sep 18, 2019

@alejandratenorio ok! Sounds great! We discussed this issue during our weekly design meeting and we're ready for a pull request! Please let us know if there's anything you need! I'm happy to help with docs, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants