-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth 2.0 - Microsoft #6155
Comments
@alejandratenorio hi! Thanks for your interest in contributing to Dataverse! I was just clicking around https://data.cimmyt.org and noticed that the Microsoft login makes use of an HTTP Basic Auth pop ("Authentication Required") as in the screenshots below: Was the HTTP Basic Auth popup a design choice? The other OAuth providers look more like this with the standard OAuth login flow (Google shown below): Please let us know. Thanks! Also, I wanted to let you (and others) know that over at http://guides.dataverse.org/en/4.16/installation/shibboleth.html#shibboleth-and-adfs there are some instructions for logging into ADFS/Active Directory through Shibboleth/SAML instead of OAuth. I just mention this so that when it comes time to document the feature we can explain that there are multiple options (SAML and OAuth) for getting login to Microsoft working. |
Hello @pdurbin, Basic Auth pop was a specific condition for CIMMYT, to limit log-in to email addresses ending in @cgiar.org. Without the Basic Auth pop look like, |
@alejandratenorio ok! Sounds great! We discussed this issue during our weekly design meeting and we're ready for a pull request! Please let us know if there's anything you need! I'm happy to help with docs, etc. |
With the current OAuth2 providers, we can only connect to specific providers. We worked with Active Directory and we had to connect with Microsoft.
Similar to ORCID, GOOGLE and GitHub, we integrate Mircrosoft as OAuth2 provider in Dataverse.
The goal of CIMMYT is to contribute with this. We would like to share with you the source code for your review and comments.
The text was updated successfully, but these errors were encountered: