Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename V4.18.0.1__5991-update-scribejava.sql #6293

Closed
pdurbin opened this issue Oct 18, 2019 · 2 comments · Fixed by #6294
Closed

rename V4.18.0.1__5991-update-scribejava.sql #6293

pdurbin opened this issue Oct 18, 2019 · 2 comments · Fixed by #6294

Comments

@pdurbin
Copy link
Member

pdurbin commented Oct 18, 2019

Whoops, src/main/resources/db/migration/V4.18.0.1__5991-update-scribejava.sql should have 4.17 instead of 4.18 in it. Good catch, @landreev
@pdurbin pdurbin self-assigned this Oct 18, 2019
@pdurbin pdurbin mentioned this issue Oct 18, 2019
Closed
pdurbin added a commit that referenced this issue Oct 18, 2019
@pdurbin
use correct version in SQL upgrade script #6293
48ebf29 
Correct being defined at http://guides.dataverse.org/en/4.17/developers/sql-upgrade-scripts.html#how-to-create-a-sql-upgrade-script

"Use a version like "4.11.0.1" in the example above where the previously
released version was 4.11, ensuring that the version number is unique.
Note that this is not the version that you expect the code changes to be
included in (4.12 in this example)."
@pdurbin pdurbin mentioned this issue Oct 18, 2019
Merged
@pdurbin
Copy link
Member Author

pdurbin commented Oct 18, 2019

I just created pull request #6294 to fix this.

@pdurbin pdurbin removed their assignment Oct 18, 2019
@poikilotherm
Copy link
Contributor

Ui, nice catch! Sorry for mixing up the numbers, I had in mind that we use next release. Thanks again!

kcondon added a commit that referenced this issue Oct 21, 2019
@kcondon
Merge pull request #6294 from IQSS/6293-sql-script-rename
93270b0 
use correct version in SQL upgrade script #6293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use correct version in SQL upgrade script #6293 IQSS/dataverse
2 participants
@pdurbin @poikilotherm