Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted file with "Request Access" disabled shows empty "download" dropdown #7426

Closed
scolapasta opened this issue Nov 18, 2020 · 3 comments · Fixed by #7458
Closed

Restricted file with "Request Access" disabled shows empty "download" dropdown #7426

scolapasta opened this issue Nov 18, 2020 · 3 comments · Fixed by #7458
Assignees
Milestone

Comments

@scolapasta
Copy link
Contributor

If request access is enabled, you get a dropdown with a request access option (as designed:

image

But if request access is disabled, you get an empty dropdown:

image

@djbrooke
Copy link
Contributor

If we restore this to the previous state, it would be that just don't show any option there - there's a blank space where the request/access options usually are. I'm fine restoring it to this state instead of trying to revisit the on-page messaging right now but there's definitely some opportunity for improvement in the future.

@djbrooke djbrooke added the Small label Nov 18, 2020
@TaniaSchlatter
Copy link
Member

And there is no way to request access from the file page:
Screen Shot 2020-11-23 at 2 03 51 PM

@scolapasta
Copy link
Contributor Author

@TaniaSchlatter in the file above, it appears to me that "request access" is disabled) on the dataset. i.e the file page has the correct behavior (the dataset is showing the empty dropdown).

@sekmiller sekmiller self-assigned this Dec 1, 2020
@djbrooke djbrooke added this to the 5.3 milestone Dec 1, 2020
mheppler added a commit that referenced this issue Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants