Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev-rebuild.sh #7775

Closed
pkiraly opened this issue Apr 8, 2021 · 0 comments · Fixed by #7776
Closed

Update dev-rebuild.sh #7775

pkiraly opened this issue Apr 8, 2021 · 0 comments · Fixed by #7776

Comments

@pkiraly
Copy link
Member

pkiraly commented Apr 8, 2021

The scripts/dev/dev-rebuild.sh refers to a file which has been deleted by @poikilotherm because it has been integrated as a Flyway migration script (see #7355). He explained that the reference (lines 55-56) is no more needed, it can be removed. @pdurbin also agreed on this.

The unwanted lines:

echo "Loading SQL reference data..."
psql -U $DB_USER $DB_NAME -f scripts/database/reference_data.sql
pkiraly added a commit to pkiraly/dataverse that referenced this issue Apr 8, 2021
@pkiraly
IQSS#7775 remove unwanted lines
d7d2786
@pkiraly pkiraly mentioned this issue Apr 8, 2021
Merged
kcondon added a commit that referenced this issue Apr 12, 2021
@kcondon
Merge pull request #7776 from pkiraly/7775-update-dev-rebuild-sh
2cfb5b2 
#7775 remove unwanted lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#7775 remove unwanted lines pkiraly/dataverse
1 participant
@pkiraly