Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

".qpj" file taken out of QGIS Shapefile zip #8134

Closed
mathieu-massaviol opened this issue Oct 6, 2021 · 8 comments · Fixed by #10305
Closed

".qpj" file taken out of QGIS Shapefile zip #8134

mathieu-massaviol opened this issue Oct 6, 2021 · 8 comments · Fixed by #10305
Assignees
@Saixel
Labels
Feature: Geospatial NIH CAFE Issues related to and/or funded by the NIH CAFE project Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.
Milestone
6.2

Comments

@mathieu-massaviol
Copy link

What steps does it take to reproduce the issue?
Publishing a zipped Shapefile created with QGIS tool.

  • When does this issue occur?
    When creating a new dataset and uploading a zipped Shapefile created with QGIS

  • Which page(s) does it occurs on?
    We can see it on a dataset files tab

  • What happens?
    The Shapefile from QGIS tool has a subfile ".qpj" which is the equivalent of the ArcGis ".prj". After publishing the zipped Shapefile we can see in the files tab of the dataset that the ".qpj" has been taken out of the Shapefile zip. It seems that this file extension is unknown by dataverse.

Which version of Dataverse are you using?
v. 4.15 build 221-9a0b627

Thanks in advance for your help.

Mathieu Massaviol
@djbrooke
Copy link
Contributor

djbrooke commented Oct 6, 2021

Hi @mathieu-massaviol - since 4.15 is an older version, can you try this on demo.dataverse.org and see if you get the same behavior?

@mathieu-massaviol
Copy link
Author

Hi @djbrooke, i just tested on demo.dataverse.org and i have the same behaviour

https://demo.dataverse.org/dataset.xhtml?persistentId=doi:10.70122/FK2/OTZQNB&version=DRAFT

@pdurbin
Copy link
Member

pdurbin commented Oct 1, 2022

Related:

@pdurbin pdurbin mentioned this issue Oct 1, 2022
Open
@pdurbin pdurbin added Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. Feature: Geospatial labels Oct 9, 2022
@pdurbin
Copy link
Member

pdurbin commented Oct 9, 2022

https://demo.dataverse.org/dataset.xhtml?persistentId=doi:10.70122/FK2/OTZQNB&version=DRAFT

Sadly, the dataset and file are gone now because we clear out the demo site periodically.

@mathieu-massaviol are you able to upload a sample file to this issue? If not, would you want to add it (and a parent dataset) to our "sample data" repo? It's at https://github.com/IQSS/dataverse-sample-data

@mathieu-massaviol
Copy link
Author

@pdurbin here's a sample file from QGIS shape_with_qpj.zip

@pdurbin pdurbin added the Size: 10 A percentage of a sprint. 7 hours. label Feb 1, 2024
@pdurbin pdurbin moved this to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Feb 1, 2024
@pdurbin pdurbin moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Feb 1, 2024
@pdurbin
Copy link
Member

pdurbin commented Feb 1, 2024

@Saixel I gave you this issue because it's geospatial-related and I'm hoping it's relatively straightforward to reproduce. Please try the shape_with_qpj.zip file above and let us know if you see the same behavior, that the .qpj file has been removed from the zip file after it has been processed by Dataverse.

Then, in the code, please poke around in ShapefileHandler.java and ShapefileHandlerTest.java. I didn't write this feature but I'm pretty sure this is the right area to look at.

@cmbz cmbz added the NIH CAFE Issues related to and/or funded by the NIH CAFE project label Feb 4, 2024
@cmbz cmbz mentioned this issue Feb 4, 2024
Open
16 tasks
@Saixel Saixel mentioned this issue Feb 7, 2024
Merged
Saixel added a commit that referenced this issue Feb 8, 2024
@Saixel
Include .qpj and .qmd in Shapefile Ingest Documentation #8134
5beef2f
stevenwinship pushed a commit that referenced this issue Mar 1, 2024
@Saixel @pdurbin
Add .qpj and .qmd Extensions to Shapefile Handling #8134 (#10305)
aa9c6b0 
* Added qpj and qmd extensions to handle shapefiles

* Include .qpj and .qmd in Shapefile Ingest Documentation #8134

* Add release note for .qpj and .qmd shapefile support

* Update doc/release-notes/8134-add-qpj-qmd-extensions.md

Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>

* Add test for .qpj and .qmd file handling in ShapefileHandler

---------

Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
@pdurbin pdurbin added this to the 6.2 milestone Mar 1, 2024
@pdurbin
Copy link
Member

pdurbin commented Mar 1, 2024

@mathieu-massaviol hi! @Saixel coded up this fix...

... and it's been merged and deployed to https://beta.dataverse.org

Please feel free to try it out! Thanks!

@mathieu-massaviol
Copy link
Author

I just tested it and it works perfectly !

Thanks !

@DS-INRAE DS-INRAE moved this to Done in Recherche Data Gouv Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saixel Saixel

Labels
Feature: Geospatial NIH CAFE Issues related to and/or funded by the NIH CAFE project Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.
Projects
Recherche Data Gouv
Status: Done
Milestone
6.2
Development

Successfully merging a pull request may close this issue.

Add .qpj and .qmd Extensions to Shapefile Handling #8134 IQSS/dataverse
5 participants
@pdurbin @djbrooke @mathieu-massaviol @cmbz @Saixel