Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException when iconUrl is missing from JSON file for a license #8503

Closed
pdurbin opened this issue Mar 17, 2022 · 0 comments · Fixed by #8504
Closed

NullPointerException when iconUrl is missing from JSON file for a license #8503

pdurbin opened this issue Mar 17, 2022 · 0 comments · Fixed by #8504

Comments

@pdurbin
Copy link
Member

pdurbin commented Mar 17, 2022

This is a placeholder until we investigate more the bug that @ErykKul found and referenced in pull request #8499 (thanks!).

I'm going to reference it in a commit I have going in pull request #8502 to get LicensesIT to pass.

As of this writing (5b2820f in develop) the docs (installation/advanced.html#standardizing-custom-licenses) say that iconUrl is optional:

Defining a name, short description, URL (where it is posted), and optionally an icon URL for this license.
@qqmyers qqmyers mentioned this issue Mar 17, 2022
Merged
pdurbin added a commit that referenced this issue Mar 17, 2022
@pdurbin
for now, iconUrl is required #8501 #8503
46d12f2
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Mar 24, 2022
@poikilotherm
fix(validation): integrate refactored EMailValidator with DatasetFiel…
237d5ba 
…dValueValidator IQSS#8503

The context parameter has been removed, need to add the violation
message ourselfs. Also adding a true test for email validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IQSS/8503 make icon url optional GlobalDataverseCommunityConsortium/dataverse
1 participant
@pdurbin