Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hard coded text - My Data page #9292

Closed
josekarvalho opened this issue Jan 17, 2023 · 1 comment · Fixed by #9786
Closed

Translate hard coded text - My Data page #9292

josekarvalho opened this issue Jan 17, 2023 · 1 comment · Fixed by #9786
Labels
Feature: Internationalization Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.
Milestone

Comments

@josekarvalho
Copy link

What steps does it take to reproduce the issue?
When going to My Data menu on a user without any permissions (just registered).

  • When does this issue occur?
    Always

  • Which page(s) does it occurs on?
    /dataverseuser.xhtml?selectTab=dataRelatedToMe

  • What happens?
    No possible translation of alert text: (Sorry, nothing was found for these roles:)

  • To whom does it occur (all users, curators, superusers)?
    registered users

  • What did you expect to happen?
    make strings available to translate that message

Which version of Dataverse are you using?
5.12.1

Any related open or closed issues to this bug report?
Didn't find any

Screenshots:
Screenshot from 2023-01-17 12-02-40

@pdurbin
Copy link
Member

pdurbin commented Jan 17, 2023

@josekarvalho thanks for the bug report!

Sorry, nothing was found for these roles

Here's the hard-coded English for the message above...

https://github.com/IQSS/dataverse/blob/v5.12.1/src/main/java/edu/harvard/iq/dataverse/mydata/MyDataFinder.java#L439

... but there are other hard-coded values.

@josekarvalho if you're not aware, we plan to rewrite the front end of Dataverse: https://dataverse.org/blog/restructuring-dataverse-ui-single-page-application

... so it might make sense to defer working on this. That said, if someone wants to make a pull request, please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Internationalization Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants