Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hard coded text - File Access #9394

Closed
DS-INRAE opened this issue Feb 17, 2023 · 1 comment · Fixed by #9451
Closed

Translate hard coded text - File Access #9394

DS-INRAE opened this issue Feb 17, 2023 · 1 comment · Fixed by #9451
Milestone

Comments

@DS-INRAE
Copy link
Member

What steps does it take to reproduce the issue?

  • When does this issue occur?
    when browsing using another language than en_US

  • Which page(s) does it occurs on?
    /file.xhtml?persistentId=doi:[...]

  • What happens?
    Some dropdown headers are hard coded and can't be translated

  • To whom does it occur (all users, curators, superusers)?
    everyone

  • What did you expect to happen?
    make the following dropdown header translatable, as are (strangely) already some others already

Which version of Dataverse are you using?
5.12.1, but issue still present on the develop branch to this day

Any related open or closed issues to this bug report?
Other issue related to hard coded strings
#9292

Screenshots:
image

@pdurbin
Copy link
Member

pdurbin commented Feb 17, 2023

@DS-INRA yes, you're absolutely right. Thanks for pointing this out! Are you interested in making a pull request? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants