Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced hard coded strings in File Access button by new Bundle properties #9451

Merged
merged 1 commit into from
May 26, 2023

Conversation

DS-INRAE
Copy link
Member

@DS-INRAE DS-INRAE commented Mar 16, 2023

What this PR does / why we need it:

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I see the same changes have been included in #9493. (The commit here looks like it beat the other one by a couple weeks.)

@kcondon kcondon self-assigned this May 26, 2023
@kcondon kcondon merged commit d18ee51 into IQSS:develop May 26, 2023
@pdurbin pdurbin added this to the 5.14 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Internationalization Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: 🚀 Done (Recherche Data Gouv)
Development

Successfully merging this pull request may close these issues.

Translate hard coded text - File Access
4 participants