-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add condition for 401 on invalid key and changelog on API Guide #10127
Conversation
…elog on API Guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some feedback.
Can we have this PR also close the following issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tiny comment on style/formatting.
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added more detail as a suggestion.
In 640f69e I added a release note snippet about the new API changelog. |
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
Tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10127/4/testReport/ @landreev and @scolapasta are good with the changes as well. Merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
n/a
Suggestions on how to test this:
n/a
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
n/a
Is there a release notes update needed for this change?:
Probably we could add that now we have a changelog for the API in the general notes.
Additional documentation:
https://dataverse-guide--10127.org.readthedocs.build/en/10127/api/changelog.html