IQSS/10268 fix thumbnail selection logic #10269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nail-selection-logic
landreev
approved these changes
Jan 25, 2024
atniph
pushed a commit
to dsd-sztaki-hu/dataverse
that referenced
this pull request
May 17, 2024
The issue is partly fixed by the following commits, which are already part of the v6.2 release: IQSS#10269 IQSS#10258 Had to add "dataset.setUseGenericThumbnail(false);" line in the DatasetServiceBean to make it work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: See the issue for the description of the bug being fixed.
Which issue(s) this PR closes:
Closes #10268
Special notes for your reviewer: FWIW - I don't think we have any other way to see of there's an uploaded logo than to check and see if it exists. If there's any db mechanism, we could check that instead.
Suggestions on how to test this: See the issue -create a new dataset with no datafiles/datafiles that only use default icons, upload a separate dataset logo. The old code would only show the default dataset icon in the list of datasets on the front page, with this PR you'll see the logo.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: