IQSS/10369-support legacy PID settings #10370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steven Winship <39765413+stevenwinship@users.noreply.github.com>
Co-authored-by: Steven Winship <39765413+stevenwinship@users.noreply.github.com>
Co-authored-by: Steven Winship <39765413+stevenwinship@users.noreply.github.com>
Co-authored-by: Steven Winship <39765413+stevenwinship@users.noreply.github.com>
2 tasks
pdurbin
requested changes
Mar 13, 2024
|
Closed in favor of #10374. FWIW, the additional commits in this PR are just the ones from the multipid branch which are already merged into develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: A late reshuffle of the code added a return after looking for the new PID provider settings, bypassing the check of legacy settings. This PR removes the return so that legacy settings are checked again.
Which issue(s) this PR closes:
Closes #10369
Special notes for your reviewer:
Suggestions on how to test this: Deploy to an existing db with legacy settings. Prior to the PR the ConfigCheck will cause the deploy to fail. With the PR, it works. (If you don't have an existing setup, run a new setup, add the legacy settings, e.g. for a FAKE provider, and then remove the -Ddataverse.pid.providers= and -Ddataverse.pid.default-provider= jvm options. Trying to restart at that point will fail, but after the PR you can deploy.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: