adding api for new mdc processing state db table #10424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stevenwinship
added
pm.GREI-d-1.5.1
scolapasta
requested changes
Mar 27, 2024
scolapasta
approved these changes
Mar 27, 2024
This comment has been minimized.
This comment has been minimized.
pdurbin
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Info about new APIs need to be the guides.
Also, I'm wondering about a potentially backward-incompatible change.
@stevenwinship I'm sending this back to you but I'll test what's here.
|
Oh also https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10424/7/testReport/junit/edu.harvard.iq.dataverse.api/HarvestingClientsIT/testHarvestingClientRun_AllowHarvestingMissingCVV_False/ is failing but I assume its transient since run 6 was fine. |
pdurbin
reviewed
Mar 27, 2024
src/main/java/edu/harvard/iq/dataverse/api/MakeDataCountApi.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
After a little back and forth, we're good. Merging. |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps track of the processing state of each of the tar files combating log data for MDC. This allows for re-running failed logs and tracking failures as reported by counter_processor.
Does not close the issue IQSS/dataverse.harvard.edu#3 but is a dependency
Special notes for your reviewer:
Suggestions on how to test this: Simple CRUD apis for makedatacountprocessstate table
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: Needs docs for new APIs. release notes included
Additional documentation:
https://dataverse-guide--10424.org.readthedocs.build/en/10424/developers/make-data-count.html