Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jQuery to get search working in guides #10456

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Apr 2, 2024

What this PR does / why we need it:

Sometime after 6.1, search stopped working in the guides.

Which issue(s) this PR closes:

Special notes for your reviewer:

I'm not sure why jQuery can't be found anymore. I found this solution here:

Suggestions on how to test this:

Test the doc preview generated by this pull request. For example, here's a search for "data": https://dataverse-guide--10456.org.readthedocs.build/en/10456/search.html?q=data&check_keywords=yes&area=default

Here is a tarball from build html, built from this branch: build.tar.gz

And here is an epub, also build from this branch: Dataverse.epub.tar.gz

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

No.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@landreev landreev merged commit 8adee66 into develop Apr 2, 2024
3 checks passed
@pdurbin pdurbin added this to the 6.3 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search not working in guides post 6.1
2 participants