-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use support email in the system email message "closing" text #10504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine but can you please add docs and a release note?
…ort email address in the closing text of the system emails
@pdurbin would be great if this is moved to QA |
@PaulBoon well, it's not up to me. 😄 @cmbz and @scolapasta how to do you feel about prioritizing this? Do note that for Harvard Dataverse (according to recent support tickets), the email closing already ends with a support address... "You may contact us for support at support@dataverse.harvard.edu. Thank you, ... so I suppose this means that we don't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion to change straight quotes to double quotes. (I should write this up in a style guide.)
doc/release-notes/10287-use-support-address-in-system-email-text.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
…xt.md Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
@Louis-wr it's a nice, small change. I'm ok with it being moved forward. I threw a small size on it (3). @qqmyers this is under "external commitments (Jim)" right now. I'm not sure why. @cmbz @scolapasta how do you feel about prioritizing this for an upcoming sprint? |
Okay by me, just noting though that there are a large number of items currently in Sprint Ready, so it might take a while if @scolapasta agrees. |
@PaulBoon I don't have permission to push to your fork. Can you please merge the latest from the "develop" branch into this pull request? It should resolve the error I'm seeing:
Thanks! |
…taverse into UseSupportEmailInClosingText
Changes unknown |
@pdurbin Just had some trouble pulling and pushing, but it should be ok now. |
@PaulBoon thanks, this seems to work fine. I'm seeing the email I configured (in blue, below)... ... when I put it in my docker compose file:
Merging. |
What this PR does / why we need it:
Uses the support email address (when configured) in the system email 'closing' text, which refers to contacting support.
Which issue(s) this PR closes:
Closes #10287
Special notes for your reviewer:
Suggestions on how to test this:
Force an email sent to you, for instance by requesting to change the password.
When the support email has been configured and is different from the system email it should show that at the end of the email message ('from' is still the system email).
When the support email is not configured the system email should be used instead.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Warn sysadmins that if they have set that support-email, that will be used in those emails and if they don't want that they should either change or remove it.
Additional documentation: