Datacite xml improvements #10615
Closed
Datacite xml improvements #10615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to avoid a separate tx boundary
qqmyers
added
GDCC: QDR
|
Another related issue (probably already taken into account since it's on the QDR board :) but just in case) : |
|
Just a heads up that I'm tasked with sending "Software" etc in another issue and I can only assume it will cause merge conflicts if we merge my PR first. Here's the commit: 8593d32 |
datacite_xml_improvements
|
@qqmyers can you please resolve merge conflicts? |
datacite_xml_improvements
pdurbin
reviewed
Sep 9, 2024
| @@ -1123,4 +1123,23 @@ private boolean tagExists(String tagLabel) { | |||
| } | |||
There was a problem hiding this comment.
I'll just leave this comment here on the first file that is changed...
Can we please get a release note?
cmbz
added
Status: Waiting for Related Issues/PRs
|
Closing in favor of #10632, which now has some bug fixes in the XML that haven't been back-ported to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note - this is a subset of the changes in #10632 / #10632 adds relatedPublication relationType in addition to updating the XML sent to DataCite as described here. Nominally only #10632 needs to be merged, but this could be merged first to make it easier to see just the relationType changes in #10632.
What this PR does / why we need it: This PR updates the XML sent to DOI providers to be richer and more consistent with what is in the OpenAire export. There are differences (most obviously, the code here works for draft datasets and files which are not handled by the OpenAire exporter), most are probably subtle but @jggautier or others may wish to look at/comment on the list of changes I've tried to track in this doc.
This is nominally one of 2 PRs related to DOI metadata - the other will be a change to the citation metadatablock to add a relationshipType to the field(s) where we expect to report the relationships to DataCite/etc.
Which issue(s) this PR closes:
Probably closes #5889 when combined with the relationshipType PR.
Closes #
Special notes for your reviewer: The PR includes some refactoring of our XML generation code that is common with the DDI export. @poikilotherm's idea of generating a model from the DataCite schema might be a good next step (hopefully easier given the code here to get the content needed).
Suggestions on how to test this: QDR is testing this code now. There is one new test in addition to the existing ones - it could/should be expanded to test a dataset with more of the metadata that is covered by the new code - possibly just reading in one of the ~complete dataset examples we have. Verification that the result matches the DataCite schema is included.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: only changes the XML sent to the DOI provider which is also exposed as a metadata export. The change makes the OpenAire export somewhat redundant, but as noted above, there are differences which may need to be kept.
Is there a release notes update needed for this change?: yes - will create once the set of changes (in the doc above) is reviewed. Probably should be combined with the citation block change if that can be created in time for the same release.
Additional documentation: