Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10719 fix manage templates display #10720

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

sekmiller
Copy link
Contributor

What this PR does / why we need it: Fixes display of Manage Templates page

Which issue(s) this PR closes:

Closes #10719 Manage Template page broken in dev

Special notes for your reviewer: two minor display changes - not 100% sure why they didn't error previously.

Suggestions on how to test this:
Make sure that you can add, edit delete and view templates. Also set default template and use a created template to add dataset.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:
Bug doesn't seem to be in production, so 'no'

Additional documentation:

@sekmiller sekmiller added the Size: 10 A percentage of a sprint. 7 hours. label Jul 24, 2024
@sekmiller sekmiller added this to the 6.4 milestone Jul 24, 2024
@landreev landreev self-assigned this Jul 24, 2024
Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@landreev landreev removed their assignment Jul 24, 2024
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10719-manage-templates-bug
ghcr.io/gdcc/configbaker:10719-manage-templates-bug

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@stevenwinship stevenwinship self-assigned this Jul 31, 2024
@stevenwinship stevenwinship merged commit c6debb5 into develop Jul 31, 2024
11 checks passed
@stevenwinship stevenwinship removed their assignment Jul 31, 2024
PaulBoon added a commit to DANS-KNAW/dataverse that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 10 A percentage of a sprint. 7 hours.
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Manage Templates page broken in Dev
3 participants