Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS 10975 - fix file replace #10979

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 29, 2024

What this PR does / why we need it: This should resolve the issue seen in #10975 related to using replace via API. It also adds the one missing piece needed to use the Fake PID provider for file PIDs, which should help with testing.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: Repeat the scenario shown in the issue, with a FAKE provider, and file PIDS enabled. Regression testing: Doing a file replace through the UI should still work, FAKE file pids should work in general, no other changes.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@coveralls
Copy link

coveralls commented Oct 29, 2024

Coverage Status

coverage: 22.569% (-0.002%) from 22.571%
when pulling da06fea on GlobalDataverseCommunityConsortium:IQSS-10975
into a4d0127 on IQSS:develop.

@qqmyers qqmyers marked this pull request as ready for review December 12, 2024 18:54
@qqmyers qqmyers marked this pull request as draft December 12, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

NativeAPI: Replace endpoint returns "Failed to add file to dataset" when file PIDs are enabled
2 participants