Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1837 implemented and ready to be merged. #2893

Merged
merged 3 commits into from
Mar 11, 2016

Conversation

michbarsinai
Copy link
Member

@michbarsinai michbarsinai commented Jan 27, 2016

Doing this via a pull request, per @pdurbin's suggestion.

@pdurbin
Copy link
Member

pdurbin commented Jan 28, 2016

This pull request is for #1837

I'm just adding this here so there's a clickable link. @michbarsinai you could also add this to the description and delete this comment.

@kcondon kcondon assigned scolapasta and unassigned kcondon Mar 11, 2016
@kcondon
Copy link
Contributor

kcondon commented Mar 11, 2016

OK, tested basic commands with key in header, command line, both with doi and with db id. Works, go ahead and merge.

scolapasta added a commit that referenced this pull request Mar 11, 2016
@scolapasta scolapasta merged commit e3f635e into develop Mar 11, 2016
@mheppler mheppler deleted the 1837-persistent-id-in-dataset-api branch September 27, 2016 18:38
@pdurbin pdurbin mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants