Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim whitespace for user email, identifier, etc. #3121

Merged
merged 1 commit into from
May 17, 2016

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented May 17, 2016

RFI Checklist

1. Related Issues


2. Pull Request Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 5.139% when pulling 8355b2d on 3044-trim-user-fields into 7fe7040 on develop.

@kcondon
Copy link
Contributor

kcondon commented May 17, 2016

@pdurbin, not sure what you meant by etc. in title. This works but for username and email only. Is that what's intended?

Just heard from Phil, just email, username and useridentifier field from authenticateduser table.

@kcondon
Copy link
Contributor

kcondon commented May 17, 2016

OK to merge

@scolapasta scolapasta merged commit 4cb23b1 into develop May 17, 2016
@scolapasta scolapasta added this to the 4.4 milestone May 17, 2016
@pdurbin pdurbin deleted the 3044-trim-user-fields branch May 31, 2016 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants