Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3091 shib ui #3126

Merged
merged 5 commits into from
May 17, 2016
Merged

3091 shib ui #3126

merged 5 commits into from
May 17, 2016

Conversation

mheppler
Copy link
Contributor

@mheppler mheppler commented May 17, 2016 •
edited by scolapasta
Loading

RFI Checklist

Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.

1. Related Issues

List and link to the issues in this Pull Request.

2. Pull Request Checklist

  • Functionality completed as described in FRD (FRD N/A)
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

@mheppler
Copy link
Contributor Author

mheppler commented May 17, 2016 •
edited
Loading

In the absence of an FRD for these minor UI issues, I have added a bulleted outline of development here.

Log In Pg

  • Fix layout issue with dropdown list of suggested items in the "Allow me to type the name of my institution" workflow under the Institutional Account section.
  • Changed error text to read "Internal Error" instead of "FATAL - DISCO UI:" when there is a problem with the environment.
  • Stretched panel wrapper around both log in options, rather than just the one Institutional Account option, with conditional render logic that shrinks the width of the panel wrapper if there is only one log in option to display.
  • Change the header text for each option to be more consistent and concise, "Dataverse Account" and "Institutional Account", removing "Log In".
  • Style and improve layout of the help text for the Institutional Account section to be cleaner
  • Fixed layout of "previous selections" logo/title blocks under the Institutional Account section on login pg so that they float next to and not on top of each other.
  • Removed text above "previous selections" logo/title blocks under the Institutional Account section on login pg, and below, use the original help text associated with the form.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.145% when pulling 6e2c297 on 3091-shib-ui into 60fb3d8 on develop.

@mheppler
Additional clean up of the layout of "previous selections" logo/title…
431e1f9 
… blocks under the Institutional Account section on login pg. [ref #3091]
@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.145% when pulling 431e1f9 on 3091-shib-ui into 60fb3d8 on develop.

@kcondon
Copy link
Contributor

kcondon commented May 17, 2016

OK to merge

@kcondon kcondon assigned scolapasta and unassigned kcondon May 17, 2016
@scolapasta scolapasta merged commit 932e532 into develop May 17, 2016
@scolapasta scolapasta added this to the 4.4 milestone May 17, 2016
@pdurbin pdurbin mentioned this pull request May 25, 2016
Closed
@mheppler mheppler deleted the 3091-shib-ui branch September 27, 2016 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scolapasta scolapasta

Labels
None yet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mheppler @coveralls @kcondon @scolapasta