Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik integration #3374

Merged
merged 3 commits into from
Sep 27, 2016
Merged

Piwik integration #3374

merged 3 commits into from
Sep 27, 2016

Conversation

jri-sp
Copy link
Contributor

@jri-sp jri-sp commented Sep 22, 2016

RFI Checklist

1. Related Issues


2. Pull Request Checklist

  • Functionality completed as described in FRD (no FRD)
  • Dependencies, risks, assumptions in FRD addressed (no FRD)
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived (-@raprasad)
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

Connects to #3018

jri-sp added 3 commits March 15, 2016 14:19
Javascript is from Piwik application. Load snippet only if variables are set.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 7.931% when pulling d195f88 on jri-sp:develop into 2df5aea on IQSS:develop.

@pdurbin
Copy link
Member

pdurbin commented Sep 22, 2016

I just dragged this pull request to "Code Review" at https://waffle.io/IQSS/dataverse

The change is pretty small and seems to add a lot of value for installations that are into Piwiki.

The corresponding issue (#3018) is still under "Backlog" and I have encouraged @jri-sp and @rmo-cdsp to call in via http://dataverse.org/community-calls to see if the issue can be moved out of the backlog. See our full conversation at http://irclog.iq.harvard.edu/dataverse/2016-09-22

Copy link
Contributor

@raprasad raprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pdurbin
Copy link
Member

pdurbin commented Sep 23, 2016

#3018 is in the 4.5.1 milestone so I'll put this there as well.

@pdurbin pdurbin added this to the 4.5.1 - IP Groups fixes milestone Sep 23, 2016
@kcondon kcondon merged commit efc83c6 into IQSS:develop Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants