Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow file add to datasets with exisiting files #3454 #3457

Closed
wants to merge 1 commit into from

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Nov 4, 2016

RFI Checklist

1. Related Issues


2. Pull Request Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • API tests completed (had to fix a bug in FileMetadataIT)
  • Deployment requirements identified (e.g., SQL scripts, indexing) (3354-alt-checksum.sql and 3405-filemetadata-directory-label.sql have been consolidated into upgrade_v4.5.1_to_v4.6.sql)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

Also, consolidate SQL upgrade scripts and persist nulls rather than
empty strings for directoryLabel.

Also, consolidate SQL upgrade scripts and persist nulls rather than
empty strings for directoryLabel.
Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great... Pushing into QA.

@kcondon
Copy link
Contributor

kcondon commented Nov 22, 2016

Added to 3459, closing this.

@kcondon kcondon closed this Nov 22, 2016
@kcondon kcondon deleted the 3454-cannot-add-files branch November 22, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants