Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1136 enable more cors #3552

Merged
merged 4 commits into from
Jan 17, 2017
Merged

1136 enable more cors #3552

merged 4 commits into from
Jan 17, 2017

Conversation

michbarsinai
Copy link
Member

RFI Checklist

Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.

1. Related Issues


2. Pull Request Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

@michbarsinai
Copy link
Member Author

Testing this PR:

  1. Re-create the user guide
  2. For each endpoint in the native api that has a CORS label next to it, validate that the response headers contain Access-Control-Allow-Origin with the value *
  3. Other endpoints should not have this header
  4. It might also make sense to have other people validate my choice of CORS-allowed endpoints, in case I've missed something.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 8.728% when pulling 44f4936 on 1136-enable-more-CORS into 52e9ec3 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 8.76% when pulling fdb7035 on 1136-enable-more-CORS into 52e9ec3 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 8.76% when pulling 575acd7 on 1136-enable-more-CORS into 52e9ec3 on develop.

@kcondon kcondon merged commit efe501c into develop Jan 17, 2017
@kcondon kcondon deleted the 1136-enable-more-CORS branch January 17, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants