Re-enabling counting API downloads/creating guestbookresponses #4434
Conversation
…ponse object)... It appears to be working now. But I'm having some doubts now - was it actually disabled *on purpose*, for whatever reason? - Will make a PR and ask on slack... (#3331)
| if (gbrecs == null && df.isReleased()){ | ||
| //commenting out for 4.6 SEK | ||
| // gbr = guestbookResponseService.initDefaultGuestbookResponse(df.getOwner(), df, session); | ||
| // commenting out for 4.6 SEK - ?? |
There was a problem hiding this comment.
I mentioned to @sekmiller this morning that if he's ok with it, we should simply remove this "commenting out" comment.
There was a problem hiding this comment.
I changed the comment to explain what we're doing here - that is writing a default gb response if the response hasn't been written via the interface
|
Looks good. I will pass to QA. One thing I noticed is that we seem to suppress the download URL on the file landing page if there is a Guestbook present. Probably should still do so in order to try to force the user to go through the interface for downloading. If download is done via the api while a GB is present on the dataset then any custom questions are ignored and required fields are not validated. |
|
@sekmiller good point. #2911 (File API download bypasses terms of use) is highly related to all of this. I'd still like to have that comment removed, if you don't mind. This one: |
|
As of 140c4cc Failed tests: testCreateDataverseCreateDatasetUploadFileDownloadFileEditTitle(edu.harvard.iq.dataverse.api.SwordIT): expected:<404> but was:<500> |
Unrelated to issue 3331, but I needed a convenient branch to put this on. Updated a citation at Gary's request, and fixed a few formatting bugs I noticed on this branch's docs.
pdurbin
modified the milestones:
4.9 - Persistent Identifiers for Files,
4.8.6 Modular Explore, AWS Improvements, New APIs
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist